docs(planner): add power-aware design - #12701
Conversation
Signed-off-by: Kai Ma <kaim@nvidia.com>
WalkthroughThe PR adds a Developer Guide page for static GPU power-aware Planner behavior. It documents admission, configuration, startup settlement, rollout handling, budget enforcement, metrics, tests, deferred work, and implementation references. ChangesPower-Aware Planner
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Signed-off-by: Kai Ma <kaim@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/fern/pages/developer-guide/knowledge-base/modular-components/planner/power-aware-planner-design.md`:
- Around line 8-14: Update the Tier 3 and Experimental notices in the planner
design documentation to use GitHub-style admonition syntax, using appropriate
alert types and keeping each alert separated by a blank line. Preserve the
existing notice text and links.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 87cb6a39-9b3d-4dca-9947-c1ba662e90d6
📒 Files selected for processing (2)
docs/fern/index.ymldocs/fern/pages/developer-guide/knowledge-base/modular-components/planner/power-aware-planner-design.md
|
/ok to test d4ed1d4 |
Signed-off-by: Kai Ma <kaim@nvidia.com>
Signed-off-by: Kai Ma <kaim@nvidia.com>
Signed-off-by: Kai Ma <kaim@nvidia.com>
…sign-v2 Signed-off-by: Kai Ma <kaim@nvidia.com>
|
/ok to test cf34b15 |
Signed-off-by: Kai Ma <kaim@nvidia.com>
|
Superseded by #13454. The newer PR preserves the complete power-aware Planner design and Fern navigation changes from this PR, and extends them with the Phase 2 runtime qualification contract, exact GPU product/qualification-catalog boundary, product canary procedure, and DGDR follow-up. Closing this PR in favor of #13454. |
Summary
Validation
git diff --checkpre-commit run --files docs/fern/pages/developer-guide/knowledge-base/modular-components/planner/power-aware-planner-design.mdcheck-asset-pathsbecause Python selected CP1252 for UTF-8 docs, orpytest-marker-reportbecause it imports Linux-onlyfcntl.python3 docs/fern/scripts/check_asset_paths.py(389 files checked)python3 docs/fern/scripts/convert_callouts.py --test(19 tests passed)Reviewer Guidance
Start with:
Decision Summaryfor the current static contract.Ownership and Data FlowandAdmission Contractfor component boundaries.Deferred Dynamic Control and Follow-Up Prioritiesfor the intentionally deferred design scope.The implementation is already merged in #12012. This PR documents that behavior; it does not add runtime functionality.
Related Issues