fix: resolve local dev container build issues

[t-ob]

Overview:

Fix for local dev container build. I ran into this today trying to follow the instructions in .devcontainer/README.md.

Details:

First, running

./container/build.sh --target local-dev

failed with a permissions error in Dockerfile.vllm. Moving the pip install invocation to before changing user seems to have resolved it.

Second, it doesn't seem like there is a python feature any more? At least, cargo build was failing with:

+ cargo build --locked --profile dev --features mistralrs,python
error: none of the selected packages contains this feature: python
selected packages: http, dynamo-llm, dynamo-runtime, metrics, router, dynamo-run, dynamo-engine-llamacpp, dynamo-engine-mistralrs, llmctl, dynamo-tokens, libdynamo_llm
++ echo '❌ ERROR: Command failed at line 52: cargo build --locked --profile dev --features mistralrs,python'
❌ ERROR: Command failed at line 52: cargo build --locked --profile dev --features mistralrs,python
++ echo '⚠️ This was unexpected and setup was not completed. Can try to resolve yourself and then manually run the rest of the commands in this file or file a bug.'
⚠️ This was unexpected and setup was not completed. Can try to resolve yourself and then manually run the rest of the commands in this file or file a bug.

Removing python from the feature list does seem to resolve, though I'm unsure if there are any knock-on effects.

Where should the reviewer start?

container/Dockerfile.vllm

Summary by CodeRabbit

• Chores
  • Updated build configuration to remove the Python feature from the build process.
  • Adjusted the Dockerfile to install the required Python package earlier in the setup process.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

👋 Hi t-ob! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[coderabbitai]

Walkthrough

The updates adjust build configurations by modifying feature flags in a shell script and reordering the installation of a Python package in a Dockerfile. No changes were made to public APIs or exported entities.

Changes

File(s)	Change Summary
.devcontainer/post-create.sh	Removed the python feature from the cargo build command.
container/Dockerfile.vllm	Moved uv pip install maturin to before the user switch in Dockerfile.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant DevContainer Script
    participant Docker Build

    Developer->>DevContainer Script: Trigger build
    DevContainer Script->>Docker Build: Build with only 'mistralrs' feature
    Docker Build->>Docker Build: Install 'maturin' as root
    Docker Build->>Docker Build: Switch to non-root user
    Docker Build->>Docker Build: Continue with remaining setup

Loading

Possibly related PRs

• build: Fix 'uv: command not found' in TRTLLM build #1256: Addresses the installation of maturin in Dockerfiles, focusing on command usage and placement.

Suggested labels

build

Suggested reviewers

• nnshah1
• alec-flowers

Poem

In the warren where Dockerfiles dwell,
A pip install moved up—oh well!
Python features trimmed with care,
Builds now lighter, swift as air.
Rabbits hop with scripts anew,
Cheering for a cleaner brew!
🐇✨

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

container/Dockerfile.vllm (1)

301-302: Reorder maturin installation under root to fix permissions
Moving uv pip install maturin before USER $USERNAME ensures that the command runs with root privileges and avoids the previous permissions error.

Consider pinning maturin to a specific version for reproducible builds, for example:

-RUN uv pip install maturin
+RUN uv pip install maturin==<stable-version>

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b889948 and 0f5d1a9.

📒 Files selected for processing (2)

• .devcontainer/post-create.sh (1 hunks)
• container/Dockerfile.vllm (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build and Test - vllm

🔇 Additional comments (1)

.devcontainer/post-create.sh (1)

52-52: Remove obsolete python feature from Cargo build
The python feature no longer exists in the Rust packages, so dropping it from --features mistralrs aligns the script with the current codebase.

Please verify that no other scripts, CI configurations, or documentation still reference the removed python feature and update them accordingly.

[alec-flowers]

Thanks for this!

[t-ob]

Thanks @alec-flowers -- I don't believe I have permissions to merge, would you be able to on my behalf?