-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(vllm): cherry-pick worker-role flag corrections and --kv-transfer-config reference #12666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pvijayakrish
merged 1 commit into
release/1.4.0
from
dagil-nvidia/cp-6550447-vllm-config-docs
Aug 4, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Documentation link points at a release branch instead of the required main branch
The new launch-script link is written against the
release/1.4.0branch (https://github.com/ai-dynamo/dynamo/blob/release/1.4.0/examples/backends/vllm/launch/disagg.shatdocs/fern/backends/vllm/vllm-config-reference.mdx:92) instead of the branch the docs rules mandate, so the published page diverges from every other outbound source link.Impact: Readers of the published docs follow a link pinned to an old snapshot rather than the current source, which will go stale as the example evolves.
Docs style rule on links outside docs/
docs/fern/documentation-style-guide.md:277-280requires links to targets outsidedocs/to be absolute GitHub URLs of the formhttps://github.com/ai-dynamo/dynamo/blob/main/<path>. Every other GitHub link on this page and in the sibling vLLM pages usesblob/main/(e.g.docs/fern/backends/vllm/vllm-config-reference.mdx:8,docs/fern/backends/vllm/vllm-examples.mdx:48).Was this helpful? React with 👍 or 👎 to provide feedback.