fix(ci): pass image_tag to shared-deploy-test in nightly (8015) - #12642
Merged
Conversation
The nightly deploy-test jobs added in #12090 call shared-deploy-test.yml with `image_suffix`, but that workflow declares a required `image_tag` input and no `image_suffix`. GitHub rejects the whole file at parse time: .github/workflows/nightly-ci.yml (Line: 610, Col: 11): Input image_tag is required, but not provided while calling. .github/workflows/nightly-ci.yml (Line: 614, Col: 21): Invalid input, image_suffix is not defined in the referenced workflow. That is a hard "Invalid workflow file" error, so no job in nightly-ci runs at all -- the scheduled nightly has been dead since #12090 merged. Pass the full ACR tag from the corresponding copy-to-acr job, matching how pr.yaml and post-merge-ci.yml call the same workflow. shared-deploy- test.yml interpolates the value directly as `ai-dynamo/dynamo:${{ inputs.image_tag }}`, so a bare suffix such as `vllm-nightly` would not have resolved to a real image either. Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe nightly workflow now passes ACR image tags from the vLLM, SGLang, and TensorRT-LLM copy jobs to their deploy tests. ChangesNightly deploy tag propagation
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
nv-tusharma
approved these changes
Aug 4, 2026
pvijayakrish
enabled auto-merge (squash)
August 4, 2026 18:15
Contributor
Author
|
/ok to test 024471b |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly deploy-test jobs added in #12090 call shared-deploy-test.yml with
image_suffix, but that workflow declares a requiredimage_taginput and noimage_suffix. GitHub rejects the whole file at parse time:.github/workflows/nightly-ci.yml (Line: 610, Col: 11): Input image_tag
is required, but not provided while calling.
.github/workflows/nightly-ci.yml (Line: 614, Col: 21): Invalid input,
image_suffix is not defined in the referenced workflow.
That is a hard "Invalid workflow file" error, so no job in nightly-ci runs at all -- the scheduled nightly has been dead since #12090 merged.
Pass the full ACR tag from the corresponding copy-to-acr job, matching how pr.yaml and post-merge-ci.yml call the same workflow. shared-deploy- test.yml interpolates the value directly as
ai-dynamo/dynamo:${{ inputs.image_tag }}, so a bare suffix such asvllm-nightlywould not have resolved to a real image either.Summary by CodeRabbit