Skip to content

fix(ci): pass image_tag to shared-deploy-test in nightly (8015) - #12642

Merged
nvda-mesharma merged 2 commits into
mainfrom
pvijayakrish/fix-nightly-deploy-test-input
Aug 4, 2026
Merged

fix(ci): pass image_tag to shared-deploy-test in nightly (8015)#12642
nvda-mesharma merged 2 commits into
mainfrom
pvijayakrish/fix-nightly-deploy-test-input

Conversation

@pvijayakrish

@pvijayakrish pvijayakrish commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The nightly deploy-test jobs added in #12090 call shared-deploy-test.yml with image_suffix, but that workflow declares a required image_tag input and no image_suffix. GitHub rejects the whole file at parse time:

.github/workflows/nightly-ci.yml (Line: 610, Col: 11): Input image_tag
is required, but not provided while calling.
.github/workflows/nightly-ci.yml (Line: 614, Col: 21): Invalid input,
image_suffix is not defined in the referenced workflow.

That is a hard "Invalid workflow file" error, so no job in nightly-ci runs at all -- the scheduled nightly has been dead since #12090 merged.

Pass the full ACR tag from the corresponding copy-to-acr job, matching how pr.yaml and post-merge-ci.yml call the same workflow. shared-deploy- test.yml interpolates the value directly as
ai-dynamo/dynamo:${{ inputs.image_tag }}, so a bare suffix such as vllm-nightly would not have resolved to a real image either.


Open in Devin Review

Summary by CodeRabbit

  • Chores
    • Improved nightly deployment validation for vLLM, SGLang, and TensorRT-LLM.
    • Tests now consistently validate the exact container image versions prepared for deployment, helping reduce misleading failures and improving confidence in nightly build results.

The nightly deploy-test jobs added in #12090 call shared-deploy-test.yml
with `image_suffix`, but that workflow declares a required `image_tag`
input and no `image_suffix`. GitHub rejects the whole file at parse time:

  .github/workflows/nightly-ci.yml (Line: 610, Col: 11): Input image_tag
  is required, but not provided while calling.
  .github/workflows/nightly-ci.yml (Line: 614, Col: 21): Invalid input,
  image_suffix is not defined in the referenced workflow.

That is a hard "Invalid workflow file" error, so no job in nightly-ci
runs at all -- the scheduled nightly has been dead since #12090 merged.

Pass the full ACR tag from the corresponding copy-to-acr job, matching
how pr.yaml and post-merge-ci.yml call the same workflow. shared-deploy-
test.yml interpolates the value directly as
`ai-dynamo/dynamo:${{ inputs.image_tag }}`, so a bare suffix such as
`vllm-nightly` would not have resolved to a real image either.

Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
@pvijayakrish
pvijayakrish requested a review from a team as a code owner August 4, 2026 18:05
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/nightly-ci.yml
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 38a007ff-debd-466d-a35e-0a83c3f4d928

📥 Commits

Reviewing files that changed from the base of the PR and between 9909e0a and 393d8a5.

📒 Files selected for processing (1)
  • .github/workflows/nightly-ci.yml

Walkthrough

The nightly workflow now passes ACR image tags from the vLLM, SGLang, and TensorRT-LLM copy jobs to their deploy tests.

Changes

Nightly deploy tag propagation

Layer / File(s) Summary
Use copied ACR image tags
.github/workflows/nightly-ci.yml
The vLLM, SGLang, and TensorRT-LLM deploy tests now use image_tag values from their corresponding ACR copy jobs.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the cause, impact, and fix, but it omits the required Related Issues section and reviewer starting point. Add the required headings, identify the files for reviewer focus, and select either a linked issue or the confirmed no-related-issue option.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the nightly CI fix and the change from image_suffix to image_tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@pvijayakrish
pvijayakrish enabled auto-merge (squash) August 4, 2026 18:15
@pvijayakrish

Copy link
Copy Markdown
Contributor Author

/ok to test 024471b

@datadog-official

This comment has been minimized.

@nvda-mesharma
nvda-mesharma disabled auto-merge August 4, 2026 20:50
@nvda-mesharma
nvda-mesharma merged commit 40586c2 into main Aug 4, 2026
97 checks passed
@nvda-mesharma
nvda-mesharma deleted the pvijayakrish/fix-nightly-deploy-test-input branch August 4, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants