feat(request-trace): native S3 sink for request-trace records (cherry-pick #11806) - #12619
Closed
dagil-nvidia wants to merge 1 commit into
Closed
feat(request-trace): native S3 sink for request-trace records (cherry-pick #11806)#12619dagil-nvidia wants to merge 1 commit into
dagil-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: Yiqiu Liu <yiqiuliu@amazon.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
github-actions
Bot
added
feat
documentation
Contributor
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
🎯 Code Coverage (details) 🔗 Commit SHA: b84bcb3 | Docs | Datadog PR Page | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b84bcb3507
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
Collaborator
Author
|
Closing: release/1.4.0 has moved past this pick (lockfile and wheel-builder conflicts with the RC5 train), and as a post-code-freeze feature it does not justify a redo with QA closing Aug 11. The feature is merged on main (#11806) and ships with the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #11806 to
release/1.4.0. Adds a native S3RequestTraceSinkthat writes existingdynamo.request.trace.v1records directly to a bucket, parallel to the OTLP sink. No schema change, no partitioning.The original PR merged to
mainon 2026-07-30, two days after the v1.4.0 code freeze (2026-07-28), so it is not on the release branch and would otherwise slip to 1.5.0.Applies cleanly onto
release/1.4.0with no conflicts.Scope note
This is a
feat, not a fix, so it lands post-freeze under TPM approval rather than automatically. Two things reviewers should weigh:request-trace-s3cargo feature (opt-in). This changes the SBOM surface and needs an SBOM regeneration plus a CVE rescan before GA.request-trace-s3feature the S3 sink returns a build-time error rather than silently no-op'ing, so the default build path is unchanged.Original PR
3872d0037d70b5c39e90bbcf1d41c82d19144918Test plan
release/1.4.0request-trace-s3feature enabled