Skip to content

docs(dgdr): repoint moved doc links at the release tree - #12618

Merged
pvijayakrish merged 2 commits into
release/1.4.0from
dagil-nvidia/fix-dgdr-links-release-140
Aug 4, 2026
Merged

docs(dgdr): repoint moved doc links at the release tree#12618
pvijayakrish merged 2 commits into
release/1.4.0from
dagil-nvidia/fix-dgdr-links-release-140

Conversation

@dagil-nvidia

@dagil-nvidia dagil-nvidia commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Unblocks lychee on release/1.4.0. Two lines.

The DGDR README links the walkthrough and reference as absolute blob/main URLs:

https://github.com/ai-dynamo/dynamo/blob/main/docs/fern/kubernetes/dgdr-guide.md      → 404
https://github.com/ai-dynamo/dynamo/blob/main/docs/fern/kubernetes/dgdr-reference.mdx → 404

#12373 restructured the docs tree on main and moved both pages, so the URLs stopped resolving. Because they point at main rather than at this branch, the breakage lands here.

Why not just take main's version

#12373 already fixed this on main by switching to relative paths, but that commit was never cherry-picked here, and its paths would not apply: release/1.4.0 predates the restructure and still carries both pages at docs/fern/kubernetes/. Verified both targets exist on this branch.

Relative links also stop this recurring, since they resolve against the branch's own tree instead of whatever main looks like today.

Impact

lychee currently fails on every PR targeting release/1.4.0, including the two P0 cherry-picks #12595 and #12604 and the CP #12584. This is the only lychee error reported in the run.


Open in Devin Review

The DGDR README linked the walkthrough and reference as absolute
blob/main URLs. #12373 restructured the docs tree on main and moved both
pages, so those URLs now 404 and lychee fails on every PR targeting
release/1.4.0.

#12373 already fixed this on main by switching to relative paths. That
commit was never cherry-picked here, and its paths would not apply
anyway: release/1.4.0 predates the restructure and still carries the
pages at docs/fern/kubernetes/. Point at those instead.

Relative links also stop this recurring, since they resolve against the
branch's own tree rather than whatever main looks like today.

Signed-off-by: Dan Gil <dagil@nvidia.com>
@dagil-nvidia
dagil-nvidia requested a review from a team as a code owner August 4, 2026 01:31
@github-actions github-actions Bot added docs documentation Improvements or additions to documentation labels Aug 4, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@dagil-nvidia

Copy link
Copy Markdown
Collaborator Author

/ok to test 7d26763

@pvijayakrish
pvijayakrish merged commit fef7ff7 into release/1.4.0 Aug 4, 2026
88 checks passed
@pvijayakrish
pvijayakrish deleted the dagil-nvidia/fix-dgdr-links-release-140 branch August 4, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants