Skip to content

fix(vllm): expand Kimi K3 media pads at the worker - #12557

Merged
ynpandey-nv merged 1 commit into
release/1.4.0-kimi-k3-dev.1from
qiwa/cherrypick-12394-expand-kimi-k3-media
Aug 18, 2026
Merged

fix(vllm): expand Kimi K3 media pads at the worker#12557
ynpandey-nv merged 1 commit into
release/1.4.0-kimi-k3-dev.1from
qiwa/cherrypick-12394-expand-kimi-k3-media

Conversation

@furionw

@furionw furionw commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #12394 onto release/1.4.0-kimi-k3-dev.1.

Original PR: #12394
Merge commit: 0d5034a

Test Plan

Signed-off-by: furionw <qiwa@nvidia.com>
@github-actions github-actions Bot added fix backend::vllm Relates to the vllm backend multimodal labels Aug 3, 2026
@datadog-official

datadog-official Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 29.29% (-6.60%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fe40910 | Docs | Datadog PR Page | Give us feedback!

@furionw
furionw marked this pull request as ready for review August 12, 2026 16:44
@furionw
furionw requested review from a team as code owners August 12, 2026 16:44

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread components/src/dynamo/vllm/multimodal_utils/request_processor.py
Comment thread components/src/dynamo/vllm/multimodal_utils/request_processor.py
@furionw
furionw marked this pull request as draft August 12, 2026 17:18
@furionw
furionw marked this pull request as ready for review August 16, 2026 19:45
@furionw

furionw commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

The failures themselves are unrelated:

  • mypy: error in untouched components/src/dynamo/sglang/register.py.
  • rust-gpu: compile errors in untouched lib/llm/.../loader.rs.
  • vLLM amd64/arm64: dependency-contract tests detected new ec_transfer_params and locality fields; the PR’s added request-processor tests did not fail.
  • vLLM multi-GPU: unrelated Qwen text-serving timeout/server-start failure.
  • deploy-operator: conversion webhook connection refused.
  • lychee: existing broken documentation links.
  • The three status checks above are merely aggregate failures from those child jobs.

@ynpandey-nv
ynpandey-nv merged commit ccc1067 into release/1.4.0-kimi-k3-dev.1 Aug 18, 2026
86 of 96 checks passed
@ynpandey-nv
ynpandey-nv deleted the qiwa/cherrypick-12394-expand-kimi-k3-media branch August 18, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants