fix(snapshot): cherry-pick exit vLLM source without engine teardown (#12184) - #12490
Merged
nv-nmailhot merged 1 commit intoAug 3, 2026
Merged
Conversation
Signed-off-by: Schwinn Saereesitthipitak <galletas1712@users.noreply.github.com> Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
49
to
+51
| if not await snapshot_controller.wait_for_restore(): | ||
| raise SystemExit(0) | ||
| logger.info("vLLM snapshot captured successfully") | ||
| os._exit(0) |
Contributor
There was a problem hiding this comment.
🔍 SGLang snapshot path still uses SystemExit(0), leaving engine teardown on that backend
components/src/dynamo/sglang/snapshot.py:165-166 still raises SystemExit(0) in the same not-restored branch. If the motivation for os._exit(0) here (avoid engine teardown/destructors during snapshot capture, matching the TRT-LLM path) also applies to SGLang, that backend remains inconsistent and can still tear down the engine after capture. Worth confirming whether the SGLang path was intentionally left alone.
Was this helpful? React with 👍 or 👎 to provide feedback.
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
|
🎯 Code Coverage (details) 🔗 Commit SHA: 84c8431 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks merged #12184 (
be65a2136809dc74985555bc754d03b53d510108) ontorelease/1.4.0.Main PR
#12184
Test plan