Skip to content

build: bump ModelExpress to 0.5.0(OPS-7978) - #12455

Merged
dagil-nvidia merged 6 commits into
mainfrom
pvijayakrish/upgrade-mx-version
Aug 3, 2026
Merged

build: bump ModelExpress to 0.5.0(OPS-7978)#12455
dagil-nvidia merged 6 commits into
mainfrom
pvijayakrish/upgrade-mx-version

Conversation

@pvijayakrish

@pvijayakrish pvijayakrish commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Overview:

bump ModelExpress to 0.5.0(OPS-7978)


Open in Devin Review

Summary by CodeRabbit

  • Chores
    • Updated Modelexpress components to version 0.5.0.
    • Updated vLLM and SGLang configurations to use the latest Modelexpress version.

Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread Cargo.toml
Comment thread container/context.yaml
@datadog-official

datadog-official Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 2 Pipeline jobs failed

Pre Merge | rust-tests (.)   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. 1 failed test. Assertion Error: left == right failed at lib/llm/src/kv_router/indexer/mod.rs:540:9.

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pvijayakrish/upgrade-mx-version

Pre Merge | rust-tests (.)
Commit: 476e5918ce006475707ee9b11f97730922af06e0
Error (code / test):
1 failed test. Assertion Error: left == right failed at lib/llm/src/kv_router/indexer/mod.rs:540:9.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/30856773431/job/91829551810

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 45.94% (-2.38%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 476e591 | Docs | Datadog PR Page | Give us feedback!

…0 (OPS-7978)

Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
@pvijayakrish
pvijayakrish requested a review from a team as a code owner July 30, 2026 23:05
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Modelexpress dependency declarations and vLLM/SGLang container configuration values are updated from earlier versions to 0.5.0.

Changes

Modelexpress version alignment

Layer / File(s) Summary
Update Modelexpress references
Cargo.toml, container/context.yaml
ModelExpress dependencies and both vLLM and SGLang configuration values now use version 0.5.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes a brief overview and omits the required Details, reviewer-start, and Related Issues sections. Add the missing Details and reviewer-start sections, and complete the required Related Issues section with an issue link or no-issue confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: bumping ModelExpress to version 0.5.0, and includes the related issue reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Cargo.toml`:
- Around line 113-114: Regenerate Cargo.lock so modelexpress-client and
modelexpress-common resolve to version 0.5.0, then validate the workspace with
cargo check --workspace --locked. Keep lib/bindings/python excluded and commit
the updated lockfile.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b3da4b5c-890c-4359-b73a-31ffb3c045ef

📥 Commits

Reviewing files that changed from the base of the PR and between 8a753c3 and 2adbba8.

📒 Files selected for processing (2)
  • Cargo.toml
  • container/context.yaml

Comment thread Cargo.toml
Comment thread container/context.yaml
@pvijayakrish
pvijayakrish marked this pull request as draft July 30, 2026 23:15
Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
@pvijayakrish
pvijayakrish marked this pull request as ready for review August 3, 2026 19:58
@pvijayakrish
pvijayakrish requested a review from a team as a code owner August 3, 2026 19:58
@pvijayakrish

Copy link
Copy Markdown
Contributor Author

all comments were addressed in the subsequent commit today;

@dagil-nvidia
dagil-nvidia merged commit ec713cf into main Aug 3, 2026
112 of 114 checks passed
@dagil-nvidia
dagil-nvidia deleted the pvijayakrish/upgrade-mx-version branch August 3, 2026 22:55
pvijayakrish added a commit that referenced this pull request Aug 3, 2026
Cherry-pick of #12455 (2adbba8 + e648ff7) onto release/1.4.0; lockfiles regenerated on the release base.

Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
hhzhang16 added a commit that referenced this pull request Aug 4, 2026
dyn-3691-extract-shared-target-pid-cuda-customstorage-operation-layer

* 'main' of https://github.com/ai-dynamo/dynamo: (50 commits)
  docs(cli): correct removed vLLM prefill-worker flag reference (#12581)
  docs(operator): reserve webhook Ignore for emergencies (#12563)
  ci(docs): make previews and checks match what actually publishes (#12339)
  refactor(vllm): organize custom encoder modules (#12416)
  feat(llm): Select reasoning output field via env var (#11464)
  feat(runtime): add TLS support to TCP request plane (#10921)
  fix: convert conditional disagg sglang warning to httperror 400 (#12578)
  feat(operator): add runtime feature gates (#12421)
  refactor(runtime): extract PushRouter transport seam behind StreamingDispatch trait (#12447)
  feat(replay): add deterministic canonical offline reports (#12363)
  build: bump ModelExpress to 0.5.0(OPS-7978) (#12455)
  fix(mocker): use logical KV tokens for decode timing (#12583)
  fix(examples): update Triton example for CUDA 13 + fix libdcgm copy (DYN-3697) (#12577)
  refactor(operator): implement composition-first DGD reconciliation (#12283)
  feat(frontend): add basetenkenizer backend (#12376)
  fix(profiler): configure rapid mocker without planner (#12573)
  docs(vllm): correct worker-role flags and document --kv-transfer-config (#12568)
  ci: add Kubernetes deploy test to nightly (#12090)
  fix(container): reuse pinned protoc in runtime image (#12535)
  feat(self-host): flip DYN_SELF_HOST_METADATA default to ON (gh-8749) (#11417)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants