Skip to content

fix(sglang): route resolved ServerArgs updates through override - #12393

Closed
furionw wants to merge 1 commit into
qiwa/k3-native-frontendfrom
qiwa/sglang-server-args-override
Closed

fix(sglang): route resolved ServerArgs updates through override#12393
furionw wants to merge 1 commit into
qiwa/k3-native-frontendfrom
qiwa/sglang-server-args-override

Conversation

@furionw

@furionw furionw commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add one compatibility helper for post-resolution SGLang ServerArgs updates
  • use ServerArgs.override on frozen newer SGLang versions
  • retain direct assignment for older SGLang and SimpleNamespace stubs
  • route all current Dynamo post-resolution mutations through the helper

Stack

Base: PR1, qiwa/k3-native-frontend

PR4 depends on this PR.

Validation

  • pre-commit run --all-files
  • Python bytecode compilation
  • unit coverage for modern override and legacy fallback paths

@datadog-official

datadog-official Bot commented Jul 29, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 14.77% (-27.22%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b69d6f7 | Docs | Datadog PR Page | Give us feedback!

@furionw furionw closed this Jul 30, 2026
@furionw
furionw deleted the qiwa/sglang-server-args-override branch July 30, 2026 02:39
@furionw
furionw restored the qiwa/sglang-server-args-override branch July 30, 2026 02:43
@furionw
furionw deleted the qiwa/sglang-server-args-override branch July 30, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::sglang Relates to the sglang backend fix size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant