docs: point README disaggregated-serving links at a published page - #12369
docs: point README disaggregated-serving links at a published page#12369dagil-nvidia wants to merge 3 commits into
Conversation
Both links pointed at docs.nvidia.com/dynamo/design-docs/disaggregated-serving, which 404s and 308-redirects to the knowledge-base path. The link checker fails on every PR as a result, blocking dynamo-status-check repo-wide. Signed-off-by: Daniel Gil <dagil@nvidia.com>
WalkthroughTwo README capability-table links were updated from the previous ChangesREADME documentation links
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
/ok to test ee96c64 |
The design-docs/* redirects in docs/fern/docs.yml target a /dynamo/dev/knowledge-base/... namespace that is not published yet, so both the source and destination URLs 404 and lychee fails on every PR. Point at the live deployment guide instead. Signed-off-by: Daniel Gil <dagil@nvidia.com>
|
/ok to test ee96c64 |
@dagil-nvidia, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test a510dea |
|
Superseded by #10855, which repointed both README links as part of the docs tab-navigation restructure and published the The remaining |
Overview
Both README links to the disaggregated-serving design doc 404. This points them at
docs.nvidia.com/dynamo/dev/kubernetes/model-deployment/disaggregated-serving, which returns 200.Root cause
docs/fern/docs.ymlredirects/dynamo/design-docs/disaggregated-servingto/dynamo/dev/knowledge-base/design-documents/disaggregated-serving. Neither URL resolves — the whole/dynamo/dev/knowledge-base/...namespace is unpublished./dynamo/design-docs/architecture-flowhas the same broken redirect, while the older/dynamo/design-docs/overall-architecturestill returns 200, so this is not limited to one page.docs/fern/design-docs/disagg-serving.mdalso does not appear in thedocs.ymlnav, so it has no published URL of its own.Why now
lycheefails on these links for every PR carrying currentmain, anddynamo-status-checkaggregates it, so it blocks merges repo-wide on code-freeze day.Follow-up
The unpublished
knowledge-basenamespace and the missing nav entry need a separate fix from the docs owners. This change only unblocks the link checker.🤖 Generated with Claude Code