-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(thunderagent): support topology-only wrapped backends #12175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ishandhanani
merged 1 commit into
ai-dynamo:main
from
cpakkamisaac-sae:fix/thunderagent-session-final-bypass
Jul 31, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
components/src/dynamo/common/utils/tests/test_endpoint_types.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Unit tests for endpoint type parsing.""" | ||
|
|
||
| import pytest | ||
|
|
||
| from dynamo.common.utils.endpoint_types import parse_endpoint_types | ||
| from dynamo.llm import ModelType | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.unit, | ||
| pytest.mark.gpu_0, | ||
| pytest.mark.pre_merge, | ||
| ] | ||
|
|
||
|
|
||
| def test_parse_endpoint_types_allows_topology_only_workers(): | ||
| assert parse_endpoint_types("none") == ModelType.Empty | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("value", ["chat,none", "none,completions"]) | ||
| def test_parse_endpoint_types_rejects_mixing_none_with_public_surfaces(value): | ||
| with pytest.raises(ValueError, match="'none' cannot be combined"): | ||
| parse_endpoint_types(value) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("value", ["", " ", ",,,"]) | ||
| def test_parse_endpoint_types_rejects_empty_input(value): | ||
| with pytest.raises(ValueError): | ||
| parse_endpoint_types(value) | ||
|
|
||
|
|
||
| def test_parse_endpoint_types_invalid_option_lists_none(): | ||
| with pytest.raises(ValueError, match="'chat', 'completions', 'none'"): | ||
| parse_endpoint_types("responses") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.