Skip to content
7 changes: 6 additions & 1 deletion tests/serve/test_sample.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
script_args=["--model-name", "Qwen/Qwen3-0.6B"],
marks=[
pytest.mark.gpu_0,
pytest.mark.timeout(300),
# CPU-mode vLLM startup for this deployment runs ~237s; a 300s
# cap left only ~20% headroom and flaked ~40% of post-merge runs
# on vllm-runtime-efa / CPU Test (the pod was killed mid-startup
# under runner contention). Match the 600s EngineConfig
# health-wait ceiling. See OPS-7728.
Comment thread
dmitry-tokarev-nv marked this conversation as resolved.
Resolved
pytest.mark.timeout(600),
Comment thread
dmitry-tokarev-nv marked this conversation as resolved.
Resolved
pytest.mark.pre_merge,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Pre-merge test with 600s timeout is very slow for the PR gate

The pytest guidelines (.ai/pytest-guidelines.md:283-284) state that tests averaging over 60 seconds should default to post_merge unless they guard a critical path. This test averages ~237s and is marked pre_merge — that was already the case before this PR (the scheduling marker is unchanged), but doubling the timeout ceiling to 600s makes the worst-case CI impact more significant. The pre-merge placement is pre-existing and outside the scope of this PR's intent, but the reviewer may want to consider whether this test should move to post_merge.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

pytest.mark.unified,
pytest.mark.vllm,
Expand Down
Loading