-
Notifications
You must be signed in to change notification settings - Fork 1.5k
build(container): restrict the in-tree ffmpeg to a narrow media-codec allowlist (OPS-7665) #11628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dmitry-tokarev-nv
wants to merge
10
commits into
main
from
dtokarev/ops-7665-ffmpeg-decoder-allowlist
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
869ddaf
build(container): restrict the in-tree ffmpeg to a narrow media-codec…
dmitry-tokarev-nv ccdf441
build(sglang): remove FFmpeg codec support
saturley-hall 3569f30
fix(sglang): remove decord2 codec libraries
saturley-hall aae72bc
chore(container): merge main into ffmpeg allowlist
saturley-hall eea17fb
Merge branch 'main' into dtokarev/ops-7665-ffmpeg-decoder-allowlist
dmitry-tokarev-nv c45909b
docs(container): address review nits on the media-codec allowlist
dmitry-tokarev-nv 642de0e
build(container): keep the h264 parser for h264_nvenc mp4 muxing
dmitry-tokarev-nv eaabac2
build(vllm): remove codec-bearing video-decode wheels from vLLM images
dmitry-tokarev-nv ddd5c05
fix(container): enable ffmpeg fd protocol for stdin encode path
dmitry-tokarev-nv 09391d2
test(serve): install video decoder at test time for codec-stripped im…
dmitry-tokarev-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,10 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Third-party Python dependencies for the sglang runtime image. Installed | ||
| # with --force-reinstall --no-deps to replace the upstream lmsysorg/sglang | ||
| # base image's imageio-ffmpeg wheel (which ships a GPL-encumbered prebuilt | ||
| # ffmpeg binary) with a source build that leaves no binary on disk. | ||
| # IMAGEIO_FFMPEG_EXE points imageio at the in-tree LGPL ffmpeg CLI. | ||
|
|
||
| --no-binary imageio-ffmpeg | ||
| # Third-party Python dependencies for the SGLang runtime image. Installed with | ||
| # --force-reinstall --no-deps so the upstream SGLang dependency stack remains | ||
| # otherwise unchanged. FFmpeg and codec-bearing wheels are removed separately | ||
| # in sglang_runtime.Dockerfile. | ||
|
|
||
| blake3>=1.0.0,<2.0.0 # Dynamo SGLang multimodal request handlers import blake3 at startup | ||
| imageio-ffmpeg>=0.6.0 # binary skipped per --no-binary directive at top of file | ||
| zstandard==0.23.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Pre-existing --disable-bsfs may affect VP9 decode in MP4 containers
The
--disable-bsfsflag atcontainer/templates/wheel_builder.Dockerfile:357was already present before this PR and disables all bitstream filters. Some demuxers/decoders use bitstream filters internally (e.g.,vp9_superframefor VP9 in MP4). If VP9-in-MP4 decode fails at runtime due to missing BSFs, this pre-existing flag would be the cause. The test fixtures were regenerated with-g 1(all keyframes), which may mask the issue since superframe handling is primarily needed for non-keyframe packets. Worth monitoring in integration tests with real-world VP9-in-MP4 content that has B-frames or superframes.(Refers to line 357)
Was this helpful? React with 👍 or 👎 to provide feedback.