fix(router): disclose selected worker in non-KV modes for 1.3.0 - #11324
Merged
saturley-hall merged 1 commit intoJul 7, 2026
Conversation
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com> (cherry picked from commit 59d6146)
ishandhanani
temporarily deployed
to
external_collaborator
July 7, 2026 15:45 — with
GitHub Actions
Inactive
ishandhanani
had a problem deploying
to
external_collaborator
July 7, 2026 15:45 — with
GitHub Actions
Failure
saturley-hall
merged commit Jul 7, 2026
b67832c
into
ai-dynamo:release/1.3.0
100 of 102 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #11245 to
release/1.3.0using the release branch's existing session-affinity API. It discloses the resolved worker for non-KV routing only after dispatch succeeds, preventing failed attempts from poisoning retry metadata.CLOSES: DYN-3353
Summary
How This Was Implemented
session_affinity/push_router.rs:release/1.3.0retains the olderprepare(request, worker_id, dp_rank)callback, whilemainuses theAffinityTargetcallback introduced by feat(router): coordinate session affinity across replicas [DYN-3249] #11079 after the release branch split.Walkthrough
Mental model
sequenceDiagram participant Router participant PushRouter participant Backend participant Tracker Router->>PushRouter: Select and prepare request PushRouter->>Backend: Dispatch to resolved worker Backend-->>PushRouter: Response stream created PushRouter->>Tracker: Record resolved worker and rankState and ordering
The tracker is removed from the prepared request and returned as dispatch metadata. Worker attribution is committed only after dispatch returns a stream; preparation or dispatch failures leave the tracker unchanged so retry and fallback paths can record the worker that actually succeeds.
Boundaries and limitations
This backport does not import the distributed-affinity work or its later revert. The public release callback remains
(worker_id, dp_rank), and existing release routing behavior remains unchanged.Validation
cargo test -p dynamo-runtime -p dynamo-llm push_router::tests --lib(41 passed)cargo clippy -p dynamo-runtime -p dynamo-llm --lib -- -D warningscargo fmt --all -- --checkgit diff --check