Skip to content

fix(sglang): support tensor image sizes for multimodal P/D - #11299

Merged
saturley-hall merged 1 commit into
release/1.3.0from
jegu/cherrypick-DYN-3390-sglang-tensor-image-size
Jul 7, 2026
Merged

fix(sglang): support tensor image sizes for multimodal P/D#11299
saturley-hall merged 1 commit into
release/1.3.0from
jegu/cherrypick-DYN-3390-sglang-tensor-image-size

Conversation

@Chokoyo

@Chokoyo Chokoyo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Cherry-pick of fix(sglang): support tensor image sizes for multimodal P/D #11255 to release/1.3.0.
  • Add the SGLang compatibility hook that derives CHW tensor image dimensions from shape[-2:] so multimodal P/D requests stay on the exact-token path.
  • Preserve the no-fallback regression coverage; the release branch additionally needs the test module's explicit logging import.

Fixes DYN-3390

Original PR

Validation

  • File-scoped pre-commit checks passed.
  • Targeted SGLang compatibility tests passed (3 passed).
  • Mypy passed for all three changed files.
  • git diff --check passed.
  • Qwen3-VL-2B same-GPU SGLang P/D E2E passed on the release worktree with NIXL and DYN_CHAT_PROCESSOR=sglang.
  • E2E returned HTTP 200 with prompt_tokens=276; SGLang prefill ran 288 tokens.
  • E2E logs contain no .height, decode+retokenize, or token drift warnings.
  • Release branch CI passes.

Signed-off-by: Zhuangcheng(Jesse) Gu <zcgu@connect.hku.hk>
@github-actions github-actions Bot added fix backend::sglang Relates to the sglang backend labels Jul 7, 2026
@Chokoyo
Chokoyo marked this pull request as ready for review July 7, 2026 02:22
@Chokoyo
Chokoyo requested review from a team as code owners July 7, 2026 02:22

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@saturley-hall
saturley-hall merged commit 01fa564 into release/1.3.0 Jul 7, 2026
92 checks passed
@saturley-hall
saturley-hall deleted the jegu/cherrypick-DYN-3390-sglang-tensor-image-size branch July 7, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::sglang Relates to the sglang backend fix size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants