ci(frontend): increase EPP build timeout - #11284
Conversation
WalkthroughThis change updates a GitHub Actions workflow file, increasing the timeout-minutes value from 20 to 45 for the frontend-only Build EPP Image step in the shared build image workflow. ChangesCI Workflow Timeout Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: None specified. Related PRs: None specified. Suggested labels: ci, workflow Suggested reviewers: None specified. 🐰 A timer ticked, then stretched its span, 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/shared-build-image.yml (1)
338-338: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider deriving from
build_timeout_minutesinstead of hardcoding.The enclosing job's timeout is parameterized (
timeout-minutes: ${{ inputs.build_timeout_minutes }}at line 184), but this step now hardcodes45. If a caller later passes a differentbuild_timeout_minutesvalue, this step will silently drift out of sync again — the same class of issue this PR is fixing.♻️ Suggested refactor
- timeout-minutes: 45 + timeout-minutes: ${{ inputs.build_timeout_minutes }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/shared-build-image.yml at line 338, The timeout on this step is hardcoded and can drift from the job-level build timeout input; update the step in shared-build-image.yml to derive its timeout from the existing build_timeout_minutes input used by the enclosing job. Use the same parameterization pattern already present in the workflow so the step stays aligned with callers’ configured timeout value instead of relying on a fixed 45 minutes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/shared-build-image.yml:
- Line 338: The timeout on this step is hardcoded and can drift from the
job-level build timeout input; update the step in shared-build-image.yml to
derive its timeout from the existing build_timeout_minutes input used by the
enclosing job. Use the same parameterization pattern already present in the
workflow so the step stays aligned with callers’ configured timeout value
instead of relying on a fixed 45 minutes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 24bbd583-6e13-4277-9eec-beb1de69d893
📒 Files selected for processing (1)
.github/workflows/shared-build-image.yml
This comment has been minimized.
This comment has been minimized.
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
5c3e78e to
bc1c46e
Compare
|
/ok to test bc1c46e |
Summary
Validation
Summary by CodeRabbit