Skip to content

ci(frontend): increase EPP build timeout - #11284

Merged
jthomson04 merged 1 commit into
mainfrom
jthomson04/ci-frontend-build-timeout
Jul 6, 2026
Merged

ci(frontend): increase EPP build timeout#11284
jthomson04 merged 1 commit into
mainfrom
jthomson04/ci-frontend-build-timeout

Conversation

@jthomson04

@jthomson04 jthomson04 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Validation

  • pre-commit run check-yaml --files .github/workflows/shared-build-image.yml
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Increased the build timeout for the frontend-only image pipeline, giving the multi-architecture image build and push step more time to complete successfully.

@jthomson04
jthomson04 marked this pull request as ready for review July 6, 2026 22:18
@jthomson04
jthomson04 requested a review from a team as a code owner July 6, 2026 22:18
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test actions labels Jul 6, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/shared-build-image.yml Outdated
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This change updates a GitHub Actions workflow file, increasing the timeout-minutes value from 20 to 45 for the frontend-only Build EPP Image step in the shared build image workflow.

Changes

CI Workflow Timeout Update

Layer / File(s) Summary
EPP image build timeout increase
.github/workflows/shared-build-image.yml
The timeout-minutes setting for the "Build EPP Image (For Frontend Only)" step is increased from 20 to 45.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: None specified.

Related PRs: None specified.

Suggested labels: ci, workflow

Suggested reviewers: None specified.

🐰 A timer ticked, then stretched its span,
From twenty minutes to forty-five's plan,
The EPP image builds without a fuss,
No rush, no panic, no needless cuss,
Just extra time for the build to run.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description misses required template sections, including Overview, Details, Where should reviewer start?, and the required Related Issues link. Add the missing template sections and either link the issue with Closes/Relates to #XXXX or check the no-issue box.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: increasing the EPP build timeout for the frontend workflow.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/shared-build-image.yml (1)

338-338: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider deriving from build_timeout_minutes instead of hardcoding.

The enclosing job's timeout is parameterized (timeout-minutes: ${{ inputs.build_timeout_minutes }} at line 184), but this step now hardcodes 45. If a caller later passes a different build_timeout_minutes value, this step will silently drift out of sync again — the same class of issue this PR is fixing.

♻️ Suggested refactor
-        timeout-minutes: 45
+        timeout-minutes: ${{ inputs.build_timeout_minutes }}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/shared-build-image.yml at line 338, The timeout on this
step is hardcoded and can drift from the job-level build timeout input; update
the step in shared-build-image.yml to derive its timeout from the existing
build_timeout_minutes input used by the enclosing job. Use the same
parameterization pattern already present in the workflow so the step stays
aligned with callers’ configured timeout value instead of relying on a fixed 45
minutes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/shared-build-image.yml:
- Line 338: The timeout on this step is hardcoded and can drift from the
job-level build timeout input; update the step in shared-build-image.yml to
derive its timeout from the existing build_timeout_minutes input used by the
enclosing job. Use the same parameterization pattern already present in the
workflow so the step stays aligned with callers’ configured timeout value
instead of relying on a fixed 45 minutes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 24bbd583-6e13-4277-9eec-beb1de69d893

📥 Commits

Reviewing files that changed from the base of the PR and between 21043cd and 5c3e78e.

📒 Files selected for processing (1)
  • .github/workflows/shared-build-image.yml

@datadog-official

This comment has been minimized.

Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
@jthomson04
jthomson04 force-pushed the jthomson04/ci-frontend-build-timeout branch from 5c3e78e to bc1c46e Compare July 6, 2026 22:28
@jthomson04

Copy link
Copy Markdown
Contributor Author

/ok to test bc1c46e

@jthomson04
jthomson04 enabled auto-merge (squash) July 6, 2026 22:33
@jthomson04
jthomson04 merged commit 56441f0 into main Jul 6, 2026
99 checks passed
@jthomson04
jthomson04 deleted the jthomson04/ci-frontend-build-timeout branch July 6, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants