perf: transcode Python request plane directly (cherry-pick of #11104) - #11283
Open
nv-yna wants to merge 1 commit into
Open
perf: transcode Python request plane directly (cherry-pick of #11104)#11283nv-yna wants to merge 1 commit into
nv-yna wants to merge 1 commit into
Conversation
Signed-off-by: jthomson04 <jwillthomson19@gmail.com> (cherry picked from commit 21043cd) Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #11104 ("perf: transcode Python request plane directly") onto
feat/deepseek_v4_aa.Mirrors the methodology from #11138 (cherry-pick of #10437 onto this same branch).
Changes included (verbatim from #11104)
lib/bindings/python/rust/python_payload.rs— new Python-native msgpack payload encoderlib/bindings/python/rust/engine.rs— use Python payload codec directly (avoid JSON round-trip)lib/bindings/python/rust/lib.rs— wiringlib/runtime/src/pipeline/network.rs—RequestPlanePayloadCodecmadepub; new default isMsgpacklib/runtime/src/pipeline/network/ingress/push_handler.rs— serialization error handlinglib/runtime/src/metrics/prometheus_names.rs—SERIALIZATIONerror variant addedtest_request_plane_python_payload.py,bidirectional_e2e_json.rstests/frontend/realtime_echo_worker.py— updated for codec changesDivergence / conflict resolution
feat/deepseek_v4_aais ~236 commits behindmain. The cherry-pick applied cleanly with no conflicts — git auto-resolved all 5 touched files (Cargo.lock,Cargo.toml,lib.rs,prometheus_names.rs,network.rs) because #10437 (the prerequisite codec PR) was already on feat as of #11138.No ambient-main symbols were introduced. Diff counts exactly match the source commit: 13 files, +1349/-270.
Build result
✅ PASS — both mandatory checks clean:
cargo check -p dynamo-runtime --tests→Finished dev profile in 23.77scargo check(Python bindings crate) →Finished dev profile in 54.40sDo NOT merge
Leave merging to @yna — rebase-merge preferred (same as #11138).
Automated cherry-pick triggered by merge of #11104.