fix(gms): rebind non-parameter tensors after publish - #11279
Merged
dagil-nvidia merged 2 commits intoJul 7, 2026
Conversation
#11201) Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
galletas1712
changed the title
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Dan Gil <dagil@nvidia.com>
dagil-nvidia
approved these changes
Jul 7, 2026
dagil-nvidia
left a comment
dagil-nvidia
left a comment
Collaborator
There was a problem hiding this comment.
Release backport quality gate: exact source patch plus focused list/tuple rebinding coverage; the named live-GMS regression passed on GPU and the full fresh rollup completed 58 passed / 36 expected skips / 0 failures at head e0cefb3.
rst0git
pushed a commit
to doublewordai/dynamo
that referenced
this pull request
Jul 14, 2026
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com> Signed-off-by: Dan Gil <dagil@nvidia.com> Co-authored-by: Dan Gil <dagil@nvidia.com> (cherry picked from commit 5295421) Signed-off-by: Radostin Stoyanov <radostin@doubleword.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #11201 to
release/1.3.0to prevent fatal GPU write faults when a GMS publisher writes mutable non-parameter tensors after the weights mapping becomes read-only.Original PR: #11201
Source merge commit:
56a74283f705166a1f8bf48f1306f42d6846287cRelease commit:
f11595767389d52ec6c4fad977674569bde1479fDependencies
None. The source PR is merged to
main, and this change has no stated PR dependency.Validation
Fresh release-branch CI at
e0cefb302da6db1e4724871f2f8f0efbcb1bdd19: 58 passed, 36 expected skips, 0 failed or pending.Exact GPU job
dynamo-runtime / test / gpu cuda13.0, amd64rantest_finalize_gms_write_rebinds_nonparameter_tensors: passed; suite summary 28 passed, 3 skipped, 0 failed.Added focused list/tuple tensor coverage; pre-commit and DCO checks passed.
Stable patch ID matches fix(gms): rebind non-parameter tensors to private memory after publish #11201:
6a2263e8bf746cda479e6ba5f2de8e7d10a0293b.pre-commit run --files lib/gpu_memory_service/client/torch/module.py lib/gpu_memory_service/integrations/common/utils.py lib/gpu_memory_service/tests/test_torch_integration.py— passed.git diff --check origin/release/1.3.0...HEAD— passed.DCO signoff is present on the release commit.
The original PR passed its live-GMS GPU regression suite (
5 passed), full pre-commit suite, and stack-level snapshot restore E2E. The GPU/live-GMS test could not be rerun locally; release-branch CI executed it successfully at the tested head.