feat(observability): Export forward pass metrics to local collectors - #11274
Closed
nealvaidya wants to merge 2 commits into
Closed
feat(observability): Export forward pass metrics to local collectors#11274nealvaidya wants to merge 2 commits into
nealvaidya wants to merge 2 commits into
Conversation
Signed-off-by: Neal Vaidya <nealv@nvidia.com>
Signed-off-by: Neal Vaidya <nealv@nvidia.com>
Contributor
Author
|
Closing as superseded by #11110, which persists forward-pass metrics at the producer as rotating JSONL gzip trace segments. The downstream SRT-Slurm and Tachometer integrations now consume that official trace format, so Dynamo no longer needs the in-process subscriber/exporter added by this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FpmEventSubscriberthrough a newrecv_envelope()API while preserving the existingrecv()behaviordynamo.common.export_forward_pass_metrics, an opt-in subscriber that discovers one or more Dynamo components and forwards decoded forward-pass metrics as NDJSON over a local Unix socketMotivation
Benchmark-scoped collectors need the full forward-pass event history from Dynamo rather than a backend-specific vLLM connection or tracking mode's latest snapshot. Keeping discovery and decoding in Dynamo provides one backend-neutral integration point for vLLM, SGLang, and TensorRT-LLM publishers.
The local socket boundary also lets a collector run without NATS: it can use etcd discovery, the configured Dynamo event plane (for example ZMQ), and a TCP request-plane runtime solely to initialize the distributed runtime.
Compatibility
FpmEventSubscriber.recv()remains unchanged for existing callers.recv()andrecv_envelope()share the existing receive mode and remain mutually exclusive withstart_tracking().Validation
cargo fmt --all -- --checkcargo check --manifest-path lib/bindings/python/Cargo.toml --libtest_export_forward_pass_metrics.py