Skip to content

fix(llm): [cherry-pick 1.3.0] reject unsupported RL fields for responses - #11265

Merged
dagil-nvidia merged 1 commit into
release/1.3.0from
jthomson04/cp-11253-release-1.3.0
Jul 7, 2026
Merged

fix(llm): [cherry-pick 1.3.0] reject unsupported RL fields for responses#11265
dagil-nvidia merged 1 commit into
release/1.3.0from
jthomson04/cp-11253-release-1.3.0

Conversation

@jthomson04

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick #11253 into release/1.3.0 so Responses API requests consistently reject unsupported RL output fields before engine dispatch.

  • Clean cherry-pick of merged commit 769c6fc51822089d8a155217ee93acafc51083f8; no conflicts.
  • Rejects completion_token_ids and prompt_logprobs when requested through nvext.extra_fields on /v1/responses.
  • Returns a field-specific 501 response for both streaming and non-streaming requests.
  • Leaves Chat Completions, Completions, and supported Responses nvext fields unchanged.

Root cause

Responses requests are converted to the Chat Completions protocol internally. The non-streaming conversion copied the resulting chat response nvext verbatim, while the Responses streaming converter did not expose those fields. This unintentionally made the RL fields available only on the non-streaming Responses path.

Where should the reviewer start?

Review validate_response_unsupported_fields and its tests in lib/llm/src/http/service/openai.rs.

Related Issues

Validation

  • cargo fmt --all -- --check
  • cargo test -p dynamo-llm test_validate_unsupported_fields --lib (8 passed)
  • cargo clippy -p dynamo-llm --lib -- -D warnings
  • git diff --check refs/remotes/origin/release/1.3.0...HEAD

Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
@github-actions github-actions Bot added fix frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` labels Jul 6, 2026
@jthomson04
jthomson04 marked this pull request as ready for review July 6, 2026 19:34
@jthomson04
jthomson04 requested a review from a team July 6, 2026 19:34

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@dagil-nvidia dagil-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release backport quality gate: exact source patch equivalence, targeted Responses API regression tests, and current CI verified at head decb8f2.

@dagil-nvidia
dagil-nvidia merged commit fc487f8 into release/1.3.0 Jul 7, 2026
101 checks passed
@dagil-nvidia
dagil-nvidia deleted the jthomson04/cp-11253-release-1.3.0 branch July 7, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants