fix(llm): [cherry-pick 1.3.0] reject unsupported RL fields for responses - #11265
Merged
Merged
Conversation
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
jthomson04
marked this pull request as ready for review
July 6, 2026 19:34
dagil-nvidia
approved these changes
Jul 7, 2026
dagil-nvidia
left a comment
Collaborator
There was a problem hiding this comment.
Release backport quality gate: exact source patch equivalence, targeted Responses API regression tests, and current CI verified at head decb8f2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #11253 into
release/1.3.0so Responses API requests consistently reject unsupported RL output fields before engine dispatch.769c6fc51822089d8a155217ee93acafc51083f8; no conflicts.completion_token_idsandprompt_logprobswhen requested throughnvext.extra_fieldson/v1/responses.nvextfields unchanged.Root cause
Responses requests are converted to the Chat Completions protocol internally. The non-streaming conversion copied the resulting chat response
nvextverbatim, while the Responses streaming converter did not expose those fields. This unintentionally made the RL fields available only on the non-streaming Responses path.Where should the reviewer start?
Review
validate_response_unsupported_fieldsand its tests inlib/llm/src/http/service/openai.rs.Related Issues
Validation
cargo fmt --all -- --checkcargo test -p dynamo-llm test_validate_unsupported_fields --lib(8 passed)cargo clippy -p dynamo-llm --lib -- -D warningsgit diff --check refs/remotes/origin/release/1.3.0...HEAD