Skip to content

docs(sglang): update HiCache requirements - #11183

Merged
jthomson04 merged 2 commits into
mainfrom
jthomson04/dyn-3352-sglang-hicache-docs
Jul 6, 2026
Merged

docs(sglang): update HiCache requirements#11183
jthomson04 merged 2 commits into
mainfrom
jthomson04/dyn-3352-sglang-hicache-docs

Conversation

@jthomson04

@jthomson04 jthomson04 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Overview:

Update the SGLang HiCache guide to replace stale PR-branch build instructions with released version requirements. The guide now distinguishes the SGLang version needed for host-tier KV events from the version that bundles the relevant Mooncake crash fix.

Details:

  • SGLang 0.5.11 is the minimum version for tier-aware shared-cache routing because it includes SGLang PR #22894 and emits CPU_PINNED host-tier events.
  • SGLang 0.5.11 through 0.5.12.x bundle Mooncake 0.3.10.post2, which is affected by the MemcpyWorkerPool crash documented in the setup warning. SGLang 0.5.13 and later bundle Mooncake 0.3.11.post1 with the upstream fix.
  • The Dynamo 1.3.0 SGLang runtime image ships SGLang 0.5.14 and satisfies both requirements.
  • Verification and troubleshooting guidance now uses version checks and upgrades instead of directing users to build an unmerged PR branch.

Where should the reviewer start?

Review the Requirements, Setup, Verification, and Troubleshooting sections in docs/backends/sglang/sglang-hicache.md.

Related Issues

🔗 This PR is linked to an issue:

Validation

  • git diff --check
  • fern check --warnings (0 errors; 2 unrelated repository-level warnings)
  • fern docs broken-links

Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 2, 2026
@datadog-official

datadog-official Bot commented Jul 2, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

Lint PR | Validate PR title and add label   View in Datadog   GitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d2e5b99 | Docs | Give us feedback!

@jthomson04 jthomson04 changed the title [codex] docs(sglang): update HiCache requirements docs(sglang): update HiCache requirements Jul 2, 2026
@github-actions github-actions Bot added the docs label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@jthomson04
jthomson04 marked this pull request as ready for review July 2, 2026 18:36
@jthomson04
jthomson04 requested a review from a team as a code owner July 2, 2026 18:36

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread docs/backends/sglang/sglang-hicache.md
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Documentation for SGLang HiCache tier-aware routing is updated to state the required change (PR #22894) is available in SGLang 0.5.14+, replacing prior guidance about building from the PR branch, and removes a 1.2.0 known-limitation warning.

Changes

HiCache Documentation Update

Layer / File(s) Summary
Version requirement and troubleshooting updates
docs/backends/sglang/sglang-hicache.md
Requirements, Setup, Verification, and Troubleshooting sections are revised to reference SGLang 0.5.14+ instead of requiring a build from PR #22894's branch, and the 1.2.0 crash limitation warning is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related Issues: None specified.

Related PRs: None specified.

Suggested labels: documentation

Suggested reviewers: None specified.

Poem:
A rabbit hopped through docs so neat,
Old PR-branch notes deleted, complete.
Now 0.5.14 leads the way,
No more crashes to keep at bay.
Hop, hop—the cache tiers align today! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change to HiCache requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description includes all required sections with clear summary, details, review location, related issue, and validation notes.

Comment @coderabbitai help to get the list of available commands.

Comment thread docs/backends/sglang/sglang-hicache.md Outdated
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
@jthomson04
jthomson04 merged commit 272202f into main Jul 6, 2026
83 of 86 checks passed
@jthomson04
jthomson04 deleted the jthomson04/dyn-3352-sglang-hicache-docs branch July 6, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants