revert(operator): register DGD admission on v1beta1 - #11175
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR migrates the dynamographdeployments webhook configuration from v1alpha1 to v1beta1 endpoints and apiVersions in the Helm chart, and updates inline comments in the defaulting and validation Go handlers with TODO notes for future v1alpha1 code removal. ChangesWebhook v1beta1 Migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Related Issues: None specified Related PRs: None specified Suggested labels: area/deploy, webhook, documentation Suggested reviewers: None specified 🥕 A webhook hops from alpha to beta, 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
|
/ok to test 61de5c2 |
|
/ok to test 61de5c2 |
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
|
/ok to test bcbf44b |
Summary
This is the registration-only follow-up to #11117 and its 1.3 backport #11130.
Validation
GOCACHE=/private/tmp/dynamo-go-cache go test ./internal/webhook/...helm lint .helm template dynamo-operator . --namespace dynamo-system --set discoveryBackend=kubernetesapiVersionsare v1beta1.Summary by CodeRabbit