Skip to content

revert(operator): register DGD admission on v1beta1 - #11175

Merged
sttts merged 4 commits into
ai-dynamo:mainfrom
sttts:sttts-dgd-admission-register-v1beta1
Jul 3, 2026
Merged

revert(operator): register DGD admission on v1beta1#11175
sttts merged 4 commits into
ai-dynamo:mainfrom
sttts:sttts-dgd-admission-register-v1beta1

Conversation

@sttts

@sttts sttts commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Switch the DGD validating and mutating webhook registrations to the v1beta1 paths and API version for 1.4.
  • Keep both v1alpha1 and v1beta1 handlers served by the operator so upgrades and rollbacks involving 1.3 remain safe.
  • Add TODO(1.5) markers to remove the legacy v1alpha1 validation and defaulting handlers after 1.3 is no longer a supported upgrade or rollback target.

This is the registration-only follow-up to #11117 and its 1.3 backport #11130.

Validation

  • GOCACHE=/private/tmp/dynamo-go-cache go test ./internal/webhook/...
  • helm lint .
  • helm template dynamo-operator . --namespace dynamo-system --set discoveryBackend=kubernetes
  • Verified the rendered validating and mutating webhook paths and apiVersions are v1beta1.

Open in Devin Review

Summary by CodeRabbit

  • Bug Fixes
    • Updated deployment webhooks to use the newer API version, improving compatibility with current cluster validation and mutation requests.
    • Aligned webhook configuration so both validation and mutation flows point to the updated endpoint format.
    • Refreshed related notes to reflect the new upgrade and removal timeline.

sttts added 2 commits July 2, 2026 15:39
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts requested a review from a team as a code owner July 2, 2026 13:41
@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sttts
sttts had a problem deploying to external_collaborator July 2, 2026 13:42 — with GitHub Actions Failure
@sttts
sttts temporarily deployed to external_collaborator July 2, 2026 13:42 — with GitHub Actions Inactive
@github-actions github-actions Bot added revert deployment::k8s Relates to dynamo deployment in kubernetes labels Jul 2, 2026
@datadog-official

This comment has been minimized.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 00662195-14b6-474a-b1cf-aa66cdc84619

📥 Commits

Reviewing files that changed from the base of the PR and between d17cdf7 and 61de5c2.

📒 Files selected for processing (3)
  • deploy/helm/charts/platform/components/operator/templates/webhook-configuration.yaml
  • deploy/operator/internal/webhook/defaulting/dynamographdeployment_handler.go
  • deploy/operator/internal/webhook/validation/dynamographdeployment_handler.go

Walkthrough

This PR migrates the dynamographdeployments webhook configuration from v1alpha1 to v1beta1 endpoints and apiVersions in the Helm chart, and updates inline comments in the defaulting and validation Go handlers with TODO notes for future v1alpha1 code removal.

Changes

Webhook v1beta1 Migration

Layer / File(s) Summary
Helm webhook configuration v1beta1 update
deploy/helm/charts/platform/components/operator/templates/webhook-configuration.yaml
Validating and mutating webhook entries for dynamographdeployments switched from v1alpha1 to v1beta1 endpoint paths and apiVersions; prior transition TODO comments removed.
Handler comment updates for v1alpha1 removal timing
deploy/operator/internal/webhook/defaulting/dynamographdeployment_handler.go, deploy/operator/internal/webhook/validation/dynamographdeployment_handler.go
Comments describing v1alpha1 endpoint retention replaced with TODO(1.5) notes specifying removal after 1.3 is no longer an upgrade/rollback target; no functional logic changed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related Issues: None specified

Related PRs: None specified

Suggested labels: area/deploy, webhook, documentation

Suggested reviewers: None specified

🥕 A webhook hops from alpha to beta,
Its paths renewed, its TODOs set free,
No logic broke, just names refined,
For version 1.5, the notes aligned.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description omits the required Overview, Details, reviewer start point, and Related Issues sections from the template. Add the template sections: Overview, Details, Where should reviewer start?, and Related Issues with the required issue linkage or no-issue confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by describing DGD admission registration on v1beta1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands.

@sttts

sttts commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 61de5c2

@sttts
sttts enabled auto-merge (squash) July 2, 2026 14:47
@sttts
sttts had a problem deploying to external_collaborator July 3, 2026 11:32 — with GitHub Actions Failure
@dmitrytokarev

Copy link
Copy Markdown

/ok to test 61de5c2

@sttts
sttts had a problem deploying to external_collaborator July 3, 2026 13:02 — with GitHub Actions Failure
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts temporarily deployed to external_collaborator July 3, 2026 13:16 — with GitHub Actions Inactive
@sttts

sttts commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test bcbf44b

@dmitry-tokarev-nv
dmitry-tokarev-nv temporarily deployed to external_collaborator July 3, 2026 17:12 — with GitHub Actions Inactive
@sttts
sttts merged commit 4808d9a into ai-dynamo:main Jul 3, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment::k8s Relates to dynamo deployment in kubernetes revert size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants