fix(operator): stage DGD admission path migration - #11129
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
|
👋 Hi sttts! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
/ok to test 107ff0f |
| - nvidia.com | ||
| apiVersions: | ||
| - v1beta1 | ||
| - v1alpha1 |
There was a problem hiding this comment.
🚩 Helm webhook apiVersion downgrade leaves v1beta1 requests unvalidated
The Helm chart changes the webhook rules from apiVersions: v1beta1 to apiVersions: v1alpha1 for both the validating and mutating DynamoGraphDeployment webhooks (webhook-configuration.yaml:98 and webhook-configuration.yaml:256). While the operator binary serves both v1alpha1 and v1beta1 endpoints (dynamographdeployment_handler.go:140-149 for defaulting, dynamographdeployment_handler.go:197-215 for validation), the Kubernetes API server only dispatches admission requests matching the registered rules. Any direct v1beta1 DynamoGraphDeployment CREATE/UPDATE requests will bypass both validation and defaulting entirely during the 1.3 release window. The TODO comments indicate this is intentional for the migration, but the reviewer should confirm that v1beta1 is not yet served by the CRD or that bypassing validation is acceptable during this period.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Validation
GOCACHE=/private/tmp/dynamo-go-cache go test ./internal/webhook/...helm lint .helm template dynamo-operator . --namespace dynamo-system --set discoveryBackend=kubernetes