Skip to content

fix(operator): stage DGD admission path migration - #11129

Closed
sttts wants to merge 2 commits into
ai-dynamo:release/1.3.0from
sttts:sttts-admission-graceful-path-change-1.3
Closed

fix(operator): stage DGD admission path migration#11129
sttts wants to merge 2 commits into
ai-dynamo:release/1.3.0from
sttts:sttts-admission-graceful-path-change-1.3

Conversation

@sttts

@sttts sttts commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Backport fix(operator): stage DGD admission path migration #11117 to the 1.3 release branch.
  • Serve both legacy v1alpha1 and v1beta1 DGD admission endpoints.
  • Convert v1alpha1 admission objects to the v1beta1 hub before validation and defaulting.
  • Keep Helm registered on the v1alpha1 routes through 1.3 so the route switch can happen safely in 1.4.

Validation

  • GOCACHE=/private/tmp/dynamo-go-cache go test ./internal/webhook/...
  • helm lint .
  • helm template dynamo-operator . --namespace dynamo-system --set discoveryBackend=kubernetes

Open in Devin Review

sttts added 2 commits July 1, 2026 19:04
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts requested a review from a team as a code owner July 1, 2026 17:11
@copy-pr-bot

copy-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sttts
sttts temporarily deployed to external_collaborator July 1, 2026 17:11 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

👋 Hi sttts! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor fix deployment::k8s Relates to dynamo deployment in kubernetes labels Jul 1, 2026
@sttts

sttts commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 107ff0f

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

- nvidia.com
apiVersions:
- v1beta1
- v1alpha1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Helm webhook apiVersion downgrade leaves v1beta1 requests unvalidated

The Helm chart changes the webhook rules from apiVersions: v1beta1 to apiVersions: v1alpha1 for both the validating and mutating DynamoGraphDeployment webhooks (webhook-configuration.yaml:98 and webhook-configuration.yaml:256). While the operator binary serves both v1alpha1 and v1beta1 endpoints (dynamographdeployment_handler.go:140-149 for defaulting, dynamographdeployment_handler.go:197-215 for validation), the Kubernetes API server only dispatches admission requests matching the registered rules. Any direct v1beta1 DynamoGraphDeployment CREATE/UPDATE requests will bypass both validation and defaulting entirely during the 1.3 release window. The TODO comments indicate this is intentional for the migration, but the reviewer should confirm that v1beta1 is not yet served by the CRD or that bypassing validation is acceptable during this period.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@datadog-official

datadog-official Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 2 Pipeline jobs failed

Pre Merge | operator   View in Datadog   GitHub Actions

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 107ff0f | Docs | Give us feedback!

@sttts

sttts commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #11130, which follows the release cherry-pick process: convention-compliant branch name and git cherry-pick --signoff of merged main commit 7e6a8c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment::k8s Relates to dynamo deployment in kubernetes external-contribution Pull request is from an external contributor fix size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant