-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(backend): add worker drain Admin API #11118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xianlubird
wants to merge
12
commits into
ai-dynamo:main
Choose a base branch
from
xianlubird:feat/worker-drain-admin-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1fbd6a5
feat(backend): add worker drain Admin API
xianlubird cbb9476
fix(backend): harden worker drain lifecycle
xianlubird bc0e097
fix(backend): address worker drain CI failures
xianlubird 4ba7fb8
chore: merge main into worker drain Admin API
xianlubird bce4014
fix(backend): harden worker drain lifecycle
xianlubird e8fedab
style(rust): apply worker lifecycle formatting
xianlubird 0362d7a
fix(llm): remove redundant stream initialization
xianlubird 4611297
Merge remote-tracking branch 'origin/main' into feat/worker-drain-adm…
xianlubird 644c419
fix(backend): address worker drain review feedback
xianlubird e8a7b94
style(runtime): apply engine route formatting
xianlubird c69da7e
chore: merge main into worker drain Admin API
xianlubird b39e335
merge: sync main into worker drain Admin API
xianlubird File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| title: Worker Admin API | ||
| subtitle: Worker-local lifecycle endpoints for draining, resuming, and checking worker state | ||
| --- | ||
|
|
||
| **Experimental.** Unified-backend workers expose lifecycle controls through the worker system-status | ||
| server. Set `DYN_SYSTEM_PORT` to zero or a positive port to enable this server. | ||
|
|
||
| <Warning> | ||
| The system-status server does not authenticate Admin API requests. Restrict the system port to the | ||
| operator network. | ||
| </Warning> | ||
|
|
||
| ## Endpoints | ||
|
|
||
| | Method | Path | Behavior | | ||
| | --- | --- | --- | | ||
| | `POST` | `/engine/drain` | Unregister the worker, wait for discovery convergence, then stop new request admission and drain admitted work | | ||
|
xianlubird marked this conversation as resolved.
|
||
| | `POST` | `/engine/resume` | Resume request admission, then re-register the worker in discovery | | ||
| | `GET` | `/engine/status` | Return the worker lifecycle status | | ||
|
|
||
| Send an empty body or an empty JSON object. Each endpoint returns the same status shape: | ||
|
|
||
| ```json | ||
| { | ||
| "state": "draining", | ||
| "inflight_requests": 2, | ||
| "discovery_registered": false | ||
| } | ||
| ``` | ||
|
|
||
| `state` is one of `serving`, `draining`, `drained`, or `stopping`. Delete a worker only when its state | ||
| is `drained`. An aggregated worker reaches `drained` after all admitted requests finish. A | ||
| disaggregated prefill worker also requires backend quiescence support. Until its backend can confirm | ||
| quiescence, it remains `draining`. | ||
|
|
||
| While discovery converges, a draining worker continues to accept requests that a frontend already | ||
| selected. After the configured graceful-shutdown grace period, the worker rejects late admissions | ||
| with a worker-draining signal that makes the frontend reselect another worker independently of the | ||
| configured migration budget, then waits for all admitted work to finish. | ||
|
|
||
| The existing `SIGTERM` graceful-shutdown path remains the default fallback and uses the same | ||
| discovery-first convergence ordering. The Admin API does not delete the worker or replace the | ||
| shutdown timeout. | ||
|
|
||
| ## Example | ||
|
|
||
| ```bash | ||
| curl --fail-with-body -X POST http://worker-host:8081/engine/drain | ||
| curl --fail-with-body http://worker-host:8081/engine/status | ||
| curl --fail-with-body -X POST http://worker-host:8081/engine/resume | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.