Repository navigation
fix: add missing llm_metrics field to tool_parser_v2 test helper - #10992
Merged
Merged
Conversation
The chunk() test helper in tool_parser_v2.rs constructs NvCreateChatCompletionStreamResponse without the llm_metrics field that was added to the struct, breaking the post-merge rust-gpu job with E0063. This is a merge-skew failure: the field was introduced by #10512 and the test helper by #10853, each green against its own base. The rust-gpu job is the only CI step that compiles these lib unit tests with the GPU feature set and runs post-merge only, so neither PR caught the broken combination. Signed-off-by: Anant Sharma <anants@nvidia.com>
nv-anants
temporarily deployed
to
external_collaborator
June 26, 2026 15:25 — with
GitHub Actions
Inactive
Contributor
WalkthroughThe streaming chat completion test helper now constructs ChangesOpenAI chat completion stream fixture
🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Comment |
keivenchang
approved these changes
Jun 26, 2026
keivenchang
left a comment
Contributor
There was a problem hiding this comment.
Thank you Anant, really appreciate it (you're too fast for me).
nv-anants
enabled auto-merge (squash)
June 26, 2026 15:52
jthomson04
approved these changes
Jun 26, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chunk() test helper in tool_parser_v2.rs constructs NvCreateChatCompletionStreamResponse without the llm_metrics field that was added to the struct, breaking the post-merge rust-gpu job with E0063 - https://github.com/ai-dynamo/dynamo/actions/runs/28245372779/job/83683622594
This is a merge-skew failure: the field was introduced by #10512 and the test helper by #10853, each green against its own base.
Summary by CodeRabbit