Skip to content

fix: add missing llm_metrics field to tool_parser_v2 test helper - #10992

Merged
nv-anants merged 1 commit into
mainfrom
anants/fix-rust-gpu-llm-metrics
Jun 26, 2026
Merged

nv-anants merged 1 commit into
mainfrom
anants/fix-rust-gpu-llm-metrics

Conversation

@nv-anants

@nv-anants nv-anants commented Jun 26, 2026 •

Copy link
Copy Markdown
Member

The chunk() test helper in tool_parser_v2.rs constructs NvCreateChatCompletionStreamResponse without the llm_metrics field that was added to the struct, breaking the post-merge rust-gpu job with E0063 - https://github.com/ai-dynamo/dynamo/actions/runs/28245372779/job/83683622594

This is a merge-skew failure: the field was introduced by #10512 and the test helper by #10853, each green against its own base.

Summary by CodeRabbit

  • Tests
    • Updated streaming chat completion test data to include the latest response field, keeping coverage aligned with current output structure.

The chunk() test helper in tool_parser_v2.rs constructs
NvCreateChatCompletionStreamResponse without the llm_metrics field that
was added to the struct, breaking the post-merge rust-gpu job with E0063.

This is a merge-skew failure: the field was introduced by #10512 and the
test helper by #10853, each green against its own base. The rust-gpu job
is the only CI step that compiles these lib unit tests with the GPU
feature set and runs post-merge only, so neither PR caught the broken
combination.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants
nv-anants requested a review from a team June 26, 2026 15:25
@nv-anants
nv-anants temporarily deployed to external_collaborator June 26, 2026 15:25 — with GitHub Actions Inactive
@github-actions github-actions Bot added fix frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` labels Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The streaming chat completion test helper now constructs NvCreateChatCompletionStreamResponse with llm_metrics: None.

Changes

OpenAI chat completion stream fixture

Layer / File(s) Summary
Add llm_metrics to chunk fixture
lib/llm/src/protocols/openai/chat_completions/tool_parser_v2.rs
The chunk helper’s NvCreateChatCompletionStreamResponse literal includes llm_metrics: None.

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description explains the bug and fix, but it omits the required template sections and lacks a Related Issues entry. Add the required Overview, Details, and Where should reviewer start sections, and complete Related Issues with a linked issue or the no-issue checkbox.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main fix: adding the missing llm_metrics field in the tool_parser_v2 test helper.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@keivenchang keivenchang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anant, really appreciate it (you're too fast for me).

@nv-anants
nv-anants enabled auto-merge (squash) June 26, 2026 15:52
@nv-anants
nv-anants merged commit a752444 into main Jun 26, 2026
103 checks passed
@nv-anants
nv-anants deleted the anants/fix-rust-gpu-llm-metrics branch June 26, 2026 16:12

This branch was previously deployed

1 inactive deployment
external_collaborator — 62d435d3 Deployed Jun 26, 2026 by nv-anants via ok-to-test #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants