ci: collapse power-agent into one job and skip test collection on top level - #10929
Closed
nv-anants wants to merge 4 commits into
Closed
ci: collapse power-agent into one job and skip test collection on top level #10929nv-anants wants to merge 4 commits into
nv-anants wants to merge 4 commits into
Conversation
…ction Merge power-agent, power-agent-test, and power-agent-helm-tests into a single power-agent job (build -> unit tests -> helm lint/render) so the PR shows one "Power Agent" check. Three same-named inline jobs do not nest the way reusable-workflow jobs (e.g. vllm-runtime) do, so they previously rendered as three separate checks. Add an optional push input (default true) to build-deploy-component so the test step builds the Dockerfile test target through the same action: routes the base image through the ECR Docker Hub mirror and reuses the runtime builder cache, while skipping the push for the never-shipped test stage. Drop the removed jobs from backend-status-check needs. Signed-off-by: Anant Sharma <anants@nvidia.com>
nv-anants
temporarily deployed
to
external_collaborator
June 24, 2026 16:35 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
Calling build-deploy-component a second time for the test re-ran the builder bootstrap and failed with "existing instance ... no append mode". Build the test target directly with docker buildx build on the builder the runtime build already set up, routing the base image through the ECR Docker Hub mirror and reusing its layer cache. Insert a builder-refresher step between the runtime and test builds (matching shared-build-image.yml) so a stale remote BuildKit connection is repaired before the test build. Revert the unused push input added to build-deploy-component. Signed-off-by: Anant Sharma <anants@nvidia.com>
The power-agent CI runs `pytest tests` with no -m filter, so the pre_merge/gpu_0/unit marks never selected anything. Remove the pytestmark lines (and the now-unused pytest import) and the marker registry from pytest.ini, and fix a stale power-agent-test job reference in the pytest.ini comment. Signed-off-by: Anant Sharma <anants@nvidia.com>
nv-anants
temporarily deployed
to
external_collaborator
June 24, 2026 16:51 — with
GitHub Actions
Inactive
nv-anants
marked this pull request as ready for review
June 24, 2026 16:55
The monorepo pytest run (dynamo-runtime test job) recursively collected deploy/power-agent/tests, whose 'tests' package name collides with the repo-root 'tests' package, producing ModuleNotFoundError collection errors. power-agent ships its own pytest.ini and runs its suite inside its container, so ignore the subtree in the root pytest addopts — same rationale as the existing duplicate-collection ignores. Signed-off-by: Anant Sharma <anants@nvidia.com>
nv-anants
temporarily deployed
to
external_collaborator
June 24, 2026 17:05 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ction
Merge power-agent, power-agent-test, and power-agent-helm-tests into a single power-agent job (build -> unit tests -> helm lint/render) so the PR shows one "Power Agent" check. Three same-named inline jobs do not nest the way reusable-workflow jobs (e.g. vllm-runtime) do, so they previously rendered as three separate checks.
Add an optional push input (default true) to build-deploy-component so the test step builds the Dockerfile test target through the same action: routes the base image through the ECR Docker Hub mirror and reuses the runtime builder cache, while skipping the push for the never-shipped test stage.
Drop the removed jobs from backend-status-check needs.
Overview:
Details:
Where should the reviewer start?
Related Issues
🔗 This PR is linked to an issue:
🚫 This PR is NOT linked to an issue: