Skip to content

ci: collapse power-agent into one job and skip test collection on top level - #10929

Closed
nv-anants wants to merge 4 commits into
pr1a/power-agentfrom
anants/power-agent-single-ci-job
Closed

ci: collapse power-agent into one job and skip test collection on top level #10929
nv-anants wants to merge 4 commits into
pr1a/power-agentfrom
anants/power-agent-single-ci-job

Conversation

@nv-anants

Copy link
Copy Markdown
Member

…ction

Merge power-agent, power-agent-test, and power-agent-helm-tests into a single power-agent job (build -> unit tests -> helm lint/render) so the PR shows one "Power Agent" check. Three same-named inline jobs do not nest the way reusable-workflow jobs (e.g. vllm-runtime) do, so they previously rendered as three separate checks.

Add an optional push input (default true) to build-deploy-component so the test step builds the Dockerfile test target through the same action: routes the base image through the ECR Docker Hub mirror and reuses the runtime builder cache, while skipping the push for the never-shipped test stage.

Drop the removed jobs from backend-status-check needs.

Overview:

Details:

Where should the reviewer start?

Related Issues

⚠️ This section is required. Choose one path below and delete the other.

🔗 This PR is linked to an issue:

  • Closes #XXXX

🚫 This PR is NOT linked to an issue:

  • Confirmed — no related issue

…ction

Merge power-agent, power-agent-test, and power-agent-helm-tests into a single power-agent job (build -> unit tests -> helm lint/render) so the PR shows one "Power Agent" check. Three same-named inline jobs do not nest the way reusable-workflow jobs (e.g. vllm-runtime) do, so they previously rendered as three separate checks.

Add an optional push input (default true) to build-deploy-component so the test step builds the Dockerfile test target through the same action: routes the base image through the ECR Docker Hub mirror and reuses the runtime builder cache, while skipping the push for the never-shipped test stage.

Drop the removed jobs from backend-status-check needs.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants
nv-anants temporarily deployed to external_collaborator June 24, 2026 16:35 — with GitHub Actions Inactive
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test actions labels Jun 24, 2026
@datadog-official

This comment has been minimized.

Calling build-deploy-component a second time for the test re-ran the builder bootstrap and failed with "existing instance ... no append mode". Build the test target directly with docker buildx build on the builder the runtime build already set up, routing the base image through the ECR Docker Hub mirror and reusing its layer cache.

Insert a builder-refresher step between the runtime and test builds (matching shared-build-image.yml) so a stale remote BuildKit connection is repaired before the test build.

Revert the unused push input added to build-deploy-component.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants nv-anants changed the title ci: collapse power-agent into one job and build test target via the a… ci: collapse power-agent into one job and remove test markers Jun 24, 2026
The power-agent CI runs `pytest tests` with no -m filter, so the pre_merge/gpu_0/unit marks never selected anything. Remove the pytestmark lines (and the now-unused pytest import) and the marker registry from pytest.ini, and fix a stale power-agent-test job reference in the pytest.ini comment.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants
nv-anants temporarily deployed to external_collaborator June 24, 2026 16:51 — with GitHub Actions Inactive
@nv-anants
nv-anants marked this pull request as ready for review June 24, 2026 16:55
@nv-anants
nv-anants requested review from a team as code owners June 24, 2026 16:55

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

The monorepo pytest run (dynamo-runtime test job) recursively collected deploy/power-agent/tests, whose 'tests' package name collides with the repo-root 'tests' package, producing ModuleNotFoundError collection errors. power-agent ships its own pytest.ini and runs its suite inside its container, so ignore the subtree in the root pytest addopts — same rationale as the existing duplicate-collection ignores.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants
nv-anants temporarily deployed to external_collaborator June 24, 2026 17:05 — with GitHub Actions Inactive
@nv-anants nv-anants changed the title ci: collapse power-agent into one job and remove test markers ci: collapse power-agent into one job and skip test collection on top level Jun 24, 2026
@nv-anants nv-anants closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant