-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(skills): restore all skills to .agents/skills #10755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .agents/skills | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After this change, ordinary edits to a canonical skill land under Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch — this is addressed in commit |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this commit adds the root
skillssymlink (or any future change retargets it), the changed-files coverage step compares the bare pathskillsfromall_all_modified_filesagainst the filter outputs and fails if no filter claims it. The pattern below only covers children such asskills/foo, not the symlink fileskillsitself, so this needs an explicitskillsentry or the PR can fail the uncovered-file check even though the alias is intentional.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against the actual
changed-filesguard run and this is already covered, so no change is needed. The bareskillspath appears inall_all_modified_filesand is also claimed by thedocsfilter (it shows up indocs_all_modified_files), so the uncovered-file check reports "All modified files are covered by CI filters." and passes. tj-actions' picomatch matches the bareskillssymlink entry under the existing docs patterns, so an explicitskillsentry would be redundant here.