Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .agents/skills

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ MR/PR. A skill invocation such as `$dynamo-clone-hotpath-audit`, "audit",
Run the read-only scanner from the repository root:

```bash
python3 .agents/contributor-skills/dynamo-clone-hotpath-audit/scripts/clone_inventory.py \
python3 .agents/skills/dynamo-clone-hotpath-audit/scripts/clone_inventory.py \
--only-actionable \
--limit 80
```

Use narrower paths when the user names a subsystem:

```bash
python3 .agents/contributor-skills/dynamo-clone-hotpath-audit/scripts/clone_inventory.py \
python3 .agents/skills/dynamo-clone-hotpath-audit/scripts/clone_inventory.py \
--paths lib/kv-router/src/scheduling lib/llm/src/backend \
--only-actionable
```
Expand Down
2 changes: 1 addition & 1 deletion .github/filters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ docs:
- '.coveragerc'
- '.claude/**'
- '.agents/**'
# Canonical agent skills directory (post-flip); .agents/skills is a symlink here.
# Canonical agent skills live in .agents/skills; root skills/ is a symlink there.
- 'skills/**'
Comment on lines +37 to 38

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cover the symlink path itself in CI filters

When this commit adds the root skills symlink (or any future change retargets it), the changed-files coverage step compares the bare path skills from all_all_modified_files against the filter outputs and fails if no filter claims it. The pattern below only covers children such as skills/foo, not the symlink file skills itself, so this needs an explicit skills entry or the PR can fail the uncovered-file check even though the alias is intentional.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the actual changed-files guard run and this is already covered, so no change is needed. The bare skills path appears in all_all_modified_files and is also claimed by the docs filter (it shows up in docs_all_modified_files), so the uncovered-file check reports "All modified files are covered by CI filters." and passes. tj-actions' picomatch matches the bare skills symlink entry under the existing docs patterns, so an explicit skills entry would be redundant here.


examples:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/nvskills-team-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ jobs:
"https://api.github.com/repos/${owner}/${repo}/pulls/${pr_number}/files?per_page=100&page=${page}")"
if printf '%s' "${files_json}" | jq -e '
any(.[]; .filename |
startswith(".agents/skills/") or
startswith("skills/") or
startswith("team-skills/") or
startswith("rules/team-rules/") or
Expand All @@ -138,7 +139,7 @@ jobs:
{
echo "## NVSkills CI request"
echo
echo "Skipped: no changes under \`skills/\`, \`team-skills/\`, \`rules/team-rules/\`, or \`plugins/\`."
echo "Skipped: no changes under \`.agents/skills/\`, \`skills/\`, \`team-skills/\`, \`rules/team-rules/\`, or \`plugins/\`."
} >> "${GITHUB_STEP_SUMMARY}"
exit 0
fi
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ the navigation in `docs/index.yml`, and running `fern check` to validate.

| Skill | Description |
|-------|-------------|
| [dynamo-docs](https://github.com/ai-dynamo/dynamo/blob/main/.agents/contributor-skills/dynamo-docs/SKILL.md) | Add, update, move, or remove a docs page |
| [dynamo-docs](../.agents/skills/dynamo-docs/SKILL.md) | Add, update, move, or remove a docs page |

---

Expand Down
2 changes: 1 addition & 1 deletion docs/digest/agentic-inference/agentic-inference.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Agent harnesses are increasingly adopting `v1/responses` and `v1/messages` over
</tr>
</table>

We have also invested in day-0 tool call and reasoning parsing support for various open-source models. If you find that a model is not supported, please [open an issue](https://github.com/ai-dynamo/dynamo/issues) or use the [tool-call-parser-generator](https://github.com/ai-dynamo/dynamo/blob/main/.agents/contributor-skills/tool-parser-generator/SKILL.md) skill to generate it with your harness of choice.
We have also invested in day-0 tool call and reasoning parsing support for various open-source models. If you find that a model is not supported, please [open an issue](https://github.com/ai-dynamo/dynamo/issues) or use the [tool-call-parser-generator](../../../.agents/skills/tool-parser-generator/SKILL.md) skill to generate it with your harness of choice.

### Agent Hints: The Harness-Orchestrator Interface

Expand Down
1 change: 1 addition & 0 deletions skills
Loading