chore(container): remove obsolete vllm v0.20.1 deepstack patch - #10282
Conversation
The vendored backport of vllm-project/vllm#40932 was added in #9491 to unblock Qwen3-VL disagg multimodal on the v0.20.1 image. The build has since moved to upstream vLLM base images (#7648), which deleted install_vllm.sh along with the patch-apply logic, leaving this patch file orphaned. vLLM is now pinned to v0.22.0, which already includes #40932 upstream, so the backport is no longer needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis PR delivers a patch that removes invalid boundary validation checks from Qwen3 model implementations. The patch eliminates ValueError-raising logic that validated num_tokens constraints against buffered deepstack_input_embeds_num_tokens during embedding retrieval and buffer operations, totaling 77 lines of removed validation code. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…namo#10282) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: shenls <shenlinshan@kanzhun.com>
…namo#10282) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: shenls <shenlinshan@kanzhun.com>
Why
PR #9491 vendored a backport of vllm-project/vllm#40932 ("remove invalid deepstack boundary check for Qwen3-VL") to unblock Qwen3-VL disagg multimodal on the
v0.20.1image. Since then the container build switched to upstream vLLM base images (#7648), which deletedinstall_vllm.shalong with the patch-apply logic — leaving the patch file orphaned, referenced by nothing in any Dockerfile or build script. vLLM is now pinned tov0.22.0, which already ships #40932 upstream, so the backport is dead weight.What Change
patches/v0.20.1/0001-pr40932-*.patch(empty parent dir goes with it)Test Plan
git grepconfirms no build-time references to the patch remain🤖 Generated with Claude Code
Summary by CodeRabbit