Skip to content

chore(container): remove obsolete vllm v0.20.1 deepstack patch - #10282

Merged
furionw merged 1 commit into
mainfrom
qiwa/rm-vllm-deepstack-patch
Jun 3, 2026
Merged

furionw merged 1 commit into
mainfrom
qiwa/rm-vllm-deepstack-patch

Conversation

@furionw

@furionw furionw commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

PR #9491 vendored a backport of vllm-project/vllm#40932 ("remove invalid deepstack boundary check for Qwen3-VL") to unblock Qwen3-VL disagg multimodal on the v0.20.1 image. Since then the container build switched to upstream vLLM base images (#7648), which deleted install_vllm.sh along with the patch-apply logic — leaving the patch file orphaned, referenced by nothing in any Dockerfile or build script. vLLM is now pinned to v0.22.0, which already ships #40932 upstream, so the backport is dead weight.

What Change

  • Delete the obsolete patches/v0.20.1/0001-pr40932-*.patch (empty parent dir goes with it)

Test Plan

  • git grep confirms no build-time references to the patch remain
  • Container build CI exercises the change (nothing consumed the patch)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Removed overly restrictive validation checks that were preventing proper operation of vision-language models under certain configurations.

The vendored backport of vllm-project/vllm#40932 was added in #9491 to
unblock Qwen3-VL disagg multimodal on the v0.20.1 image. The build has
since moved to upstream vLLM base images (#7648), which deleted
install_vllm.sh along with the patch-apply logic, leaving this patch
file orphaned. vLLM is now pinned to v0.22.0, which already includes
#40932 upstream, so the backport is no longer needed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added chore backend::vllm Relates to the vllm backend container labels Jun 3, 2026
@furionw
furionw marked this pull request as ready for review June 3, 2026 23:32
@furionw
furionw requested a review from a team as a code owner June 3, 2026 23:32
@furionw
furionw requested a review from a team June 3, 2026 23:32
@furionw
furionw requested review from a team as code owners June 3, 2026 23:32
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3b025578-cb65-4789-a112-381c522b8de4

📥 Commits

Reviewing files that changed from the base of the PR and between 32ab8da and 49efe34.

📒 Files selected for processing (1)
  • container/deps/vllm/patches/v0.20.1/0001-pr40932-remove-invalid-deepstack-boundary-check-for-qwen3-vl.patch
💤 Files with no reviewable changes (1)
  • container/deps/vllm/patches/v0.20.1/0001-pr40932-remove-invalid-deepstack-boundary-check-for-qwen3-vl.patch

Walkthrough

This PR delivers a patch that removes invalid boundary validation checks from Qwen3 model implementations. The patch eliminates ValueError-raising logic that validated num_tokens constraints against buffered deepstack_input_embeds_num_tokens during embedding retrieval and buffer operations, totaling 77 lines of removed validation code.

Changes

Cohort / File(s) Summary
Deepstack boundary check removal
container/deps/vllm/patches/v0.20.1/0001-pr40932-remove-invalid-deepstack-boundary-check-for-qwen3-vl.patch
Removes ValueError-raising boundary checks related to deepstack_input_embeds_num_tokens validation in Qwen3OmniMoeThinkerForConditionalGeneration and Qwen3VLForConditionalGeneration. No replacement validation or error handling is introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: removing an obsolete vllm v0.20.1 deepstack patch file that is no longer used.
Description check ✅ Passed The description includes a comprehensive 'Why' section explaining the context and rationale, a 'What Change' section detailing the specific deletion, and a 'Test Plan' section describing validation steps. All critical template sections are covered with substantive content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@furionw
furionw merged commit 8251319 into main Jun 3, 2026
89 checks passed
@furionw
furionw deleted the qiwa/rm-vllm-deepstack-patch branch June 3, 2026 23:56
tmonty12 pushed a commit that referenced this pull request Jun 8, 2026
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Broduker pushed a commit to Broduker/dynamo that referenced this pull request Jun 12, 2026
…namo#10282)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: shenls <shenlinshan@kanzhun.com>
Broduker pushed a commit to Broduker/dynamo that referenced this pull request Jun 12, 2026
…namo#10282)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: shenls <shenlinshan@kanzhun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants