chore(container): build in-tree ffmpeg CLI and route imageio through it (#10091)#10154
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #10091 onto
release/1.2.0.Closes OPS-6862
What
Builds the ffmpeg CLI in-tree (LGPL-only:
h264_nvenc+libvpx_vp9) and routesimageiothrough it viaIMAGEIO_FFMPEG_EXE, replacing the GPL-encumbered prebuilt binary shipped by theimageio-ffmpegwheel.Cherry-pick notes
The
release/1.2.0base had refactored the container build since #10091 was authored, so five files conflicted. The resolution applies #10091's intent onto the new structure rather than its original line layout:requirements.trtllm.txt— kept deleted; trtllm now installsrequirements.common.txt, which already carries the--no-binary imageio-ffmpegdirective.requirements.vllm.txt— kept the branch's vLLM multimodal deps; imageio handling lives inrequirements.common.txt(installed in the same step).vllm_runtime.Dockerfile— added--reinstall-package imageio-ffmpegto the existing requirements install, forcing a source rebuild that clears the base vllm image's GPL binary.trtllm_runtime.Dockerfile— added the ungated runtime ffmpeg-CLI copy +ENV IMAGEIO_FFMPEG_EXE, since the TRT-LLM diffusion handler unconditionally encodes video.wheel_builder.Dockerfile— added the nv-codec-headers + libvpx source build and switched ffmpeg./configureto build the CLI withh264_nvenc/libvpx_vp9; the newNV_CODEC_HEADERS_REF/LIBVPX_REFargs and theAWS_SDK_CPP_VERSIONdefault now flow fromargs.Dockerfile/context.yaml.Verified both the trtllm and vllm templates render cleanly via
container/render.py.🤖 Generated with Claude Code