Repository navigation
collector: pin Qwen3.8 FP8 MoE runner - #283
Merged
Arsene12358 merged 1 commit intoSep 21, 2026
Merged
Arsene12358 merged 1 commit into
Arsene12358 merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: ai-dynamo/aisimulate/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Arsene12358
force-pushed
the
yimingl/aic-1781-sglang-recipe-alignment
branch
from
September 19, 2026 04:33
685b151 to
ae39013
Compare
Arsene12358
force-pushed
the
yimingl/aic-1781-flashinfer-case-declaration
branch
from
September 19, 2026 04:33
6c138f3 to
50a099b
Compare
Arsene12358
force-pushed
the
yimingl/aic-1781-sglang-recipe-alignment
branch
from
September 21, 2026 01:33
ae39013 to
380e394
Compare
Arsene12358
force-pushed
the
yimingl/aic-1781-flashinfer-case-declaration
branch
from
September 21, 2026 01:36
50a099b to
ba4df42
Compare
Harrilee
approved these changes
Sep 21, 2026
Arsene12358
force-pushed
the
yimingl/aic-1781-sglang-recipe-alignment
branch
from
September 21, 2026 09:24
380e394 to
5a9c3b3
Compare
Arsene12358
force-pushed
the
yimingl/aic-1781-flashinfer-case-declaration
branch
from
September 21, 2026 09:48
ba4df42 to
54b98e6
Compare
Signed-off-by: Yiming Liu <yimingl@nvidia.com>
Arsene12358
force-pushed
the
yimingl/aic-1781-flashinfer-case-declaration
branch
from
September 21, 2026 10:39
54b98e6 to
26dd0c2
Compare
Arsene12358
merged commit Sep 21, 2026
b0158dc
into
yimingl/aic-1781-sglang-recipe-alignment
7 checks passed
Arsene12358
deleted the
yimingl/aic-1781-flashinfer-case-declaration
branch
September 21, 2026 14:51
Arsene12358
added a commit
that referenced
this pull request
Sep 24, 2026
* feat(perfmodel): select exact MoE kernel source Signed-off-by: Yiming Liu <yimingl@nvidia.com> * fix: enforce exact low-latency MoE eligibility Signed-off-by: Yiming Liu <yimingl@nvidia.com> * fix: preserve MoE source configuration compatibility Signed-off-by: Yiming Liu <yimingl@nvidia.com> * fix: preserve canonical config positional arguments Signed-off-by: Yiming Liu <yimingl@nvidia.com> * fix: reject ignored MoE source selections Validate exact source selections against model metadata and the constructed native operation graph before unsupported configurations can fall back. Preserve the source through external-FPM AFD validation and explicitly reject legacy or fixed companion paths that cannot consume it. Document the selector contract and cover the actual model, memory, Task, and runner consumers. Signed-off-by: Yiming Liu <yimingl@nvidia.com> * collector: pin Qwen3.8 FP8 MoE runner (#283) Signed-off-by: Yiming Liu <yimingl@nvidia.com> * test: preserve upstream attention quantization default in config checks Signed-off-by: Yiming Liu <yimingl@nvidia.com> * test: align Qwen3.8 FP8 collector expectation The deployment-specific collector declaration pins FP8 to flashinfer_trtllm on SM100 and SM103. Update the older model-case assertion that still expected the base Triton default; retain BF16 and NVFP4 coverage. The previously failing unit shard passes locally with 1930 tests passed and 6 skipped. Signed-off-by: Yiming Liu <yimingl@nvidia.com> --------- Signed-off-by: Yiming Liu <yimingl@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for the dedicated AIC-1781 per-system data PRs. This intentionally remains separate from #282, which contains only the SDK/kernel-source selector.
For Qwen3.8-Max FP8-block SGLang cases on SM100 and SM103, declare the recipe-pinned
flashinfer_trtllmMoE runner. The collector records the framework-verified exact lane assglang_flashinfer_trtllm_moe. BF16 remains on the inherited Triton default.The declaration cites the corresponding GB200 and GB300 Dynamo SGLang deployment YAMLs at commit
5fc15ee.Validation
git diff --checkThe ordinary project test environment is currently blocked by its existing Maturin package-path configuration; the focused check ran in an isolated no-project environment.