Skip to content

ci: allow qualified Pages snapshots to finish - #863

Merged
saturley-hall merged 1 commit into
mainfrom
ci/pages-qualification-timeout
Nov 13, 2026
Merged

saturley-hall merged 1 commit into
mainfrom
ci/pages-qualification-timeout

Conversation

@saturley-hall

Copy link
Copy Markdown
Member

Why and what changed

The canonical Pages deployment hit its 15-minute build-job limit during qualified FPM snapshot preparation, before site tests or publication. Increase that job limit to 30 minutes so the existing FPE, accuracy, AgentX and FPM qualification plus artifact/browser checks can complete. No qualification or publication checks are skipped.

Review map

  • Risk level: low; one timeout value changes.
  • Start with: .github/workflows/pages.yml, build job timeout-minutes.
  • Public or serialized contract changed: no.
  • Feature Support Matrix: unaffected.
  • Compatibility or rollback concern: failed builds may occupy a hosted runner for up to 30 rather than 15 minutes. The job remains bounded.

Evidence

  • Canonical deployment run 43491019429: started 19:18:54 UTC, canceled around 19:34:14. Accuracy qualification completed at 19:28:27; AgentX finished around 19:33:40; FPM preparation began then, leaving less than a minute before the job limit.
  • Actionlint v1.7.7 on this workflow and git diff --check passed locally. A diff review confirms one value changes, 15 → 30.
  • Hosted preview/CI pending; canonical deployment will be rerun after merge.
  • No new tests for this timeout adjustment; existing site validation remains unchanged.

Modeling or data provenance

N/A; qualification and data selection are unchanged.

Tracking

Repository rename rollout and #861/#862. This Pages workflow deploys from main; no release-branch change is needed.

Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
@saturley-hall
saturley-hall requested a review from a team as a code owner November 13, 2026 19:39
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Risk level: Low.

Three areas need human attention:

  1. Runner cost. Failed or stalled build runs can hold a hosted runner for up to 30 minutes, not 15.
  2. Unverified timeout sufficiency. The 30-minute limit is not tested against a full qualified snapshot run. The author cites run 43491019429 as evidence of the 15-minute limit, but no post-change run is supplied.
  3. Canonical deployment rerun. The author planned a rerun after merge. No result is supplied.

Changed behavior:

  • .github/workflows/pages.yml, build job: timeout-minutes changes from 15 to 30.
  • Diff size: 1 file, +1/-1 lines. Confirmed against merge base f3713ba.
  • No other workflow logic, qualification steps, data selection, or publication checks change.

Public contracts:

  • No public or serialized contract change, per the author and the raw summary.
  • No impact on the Feature Support Matrix, per the author.

Evidence supplied:

  • The diff confirms the single timeout change.
  • The author reports that Actionlint v1.7.7 and git diff --check passed locally.
  • The author reports that a diff review found only the timeout value changed.
  • The author cites the 15-minute limit being reached during FPM snapshot preparation in run 43491019429.

Evidence missing:

  • Hosted preview or CI results on the current head: not available.
  • A completed canonical deployment run under the 30-minute limit: not available.
  • New tests: none added. Existing site validation is unchanged.

Technical quality: The change is a one-value edit with a stated, bounded rationale. The job stays bounded.

Merge readiness: Not established. Hosted CI and a post-merge canonical deployment run are not available. The bot review is not approval.

The Pages workflow build job timeout increased from 15 to 30 minutes.

Changes: Pages build

Layer / File(s) Summary
Build job timeout
.github/workflows/pages.yml
The build job timeout increased from 15 to 30 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · up to 7a79e

This raises the Pages build timeout from 15 to 30 minutes so qualified snapshots can finish. Publication behavior is unchanged, and there is no meaningful merge risk beyond a longer worst-case runner occupancy for failed builds.

Pre-merge checks: Passed 7 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "ci: allow qualified Pages snapshots to finish" names the Pages workflow and the goal of letting snapshot preparation complete. It does not state the concrete behavioral change, which is rai… Name the behavioral change directly, for example: "ci: raise Pages build job timeout from 15 to 30 minutes". This states the change and avoids vague wording.
Passed Passed checks: 7 passed

Check name Status Explanation
Description check Passed The description follows the repository template. It covers why and what changed, a review map with risk level, starting file, contract status, and rollback concern, and an evidence section with a CI r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Cross-Layer Contract Passed The check does not apply to this PR. The check covers changed public inputs, schema fields, defaults, or outputs, and their Rust, Python, CLI, serialization, documentation, and test consumers. The PR …
Modeling And Data Evidence Passed The check is inapplicable. It covers formulas, selection logic, model or performance data, and predicted outputs. PR #863 (ai-dynamo/aisim, author saturley-hall) changes one line in a CI workflow. The…
Compatibility Boundaries Passed The check covers Python and Rust public surfaces, schemas, versions, bindings, documented defaults, AISim's standalone status relative to Dynamo, and the one-wheel plus one-crate artifact contract. Th…
Review Evidence Passed The PR description meets the Review evidence check. - Commands and results are named. It reports Actionlint v1.7.7 and git diff --check as passing locally, and it cites canonical deployment run 4349…
Full details: Description check

Explanation

The description follows the repository template. It covers why and what changed, a review map with risk level, starting file, contract status, and rollback concern, and an evidence section with a CI run link, local lint and diff checks, and the reason no new tests were added. It marks the modeling provenance as N/A. Some template fields are missing or incomplete: the Tests, Fast CI, Full CI, CodeRabbit reviewed commit, Codex reviewed commit, negative or boundary cases, and before/after output fields are not filled in. Hosted CI is still pending. The Tracking section mentions related issues but does not use the closing-keyword or plain-link format. The description is mostly complete, so it passes.

Full details: Cross-Layer Contract

Explanation

The check does not apply to this PR. The check covers changed public inputs, schema fields, defaults, or outputs, and their Rust, Python, CLI, serialization, documentation, and test consumers. The PR changes one line in .github/workflows/pages.yml: the build job timeout-minutes moves from 15 to 30 (diff hunk at line 104-107). The changed-file inventory shows only this file (M .github/workflows/pages.yml). The change does not alter any public input, schema, default used by code, or output. The PR description states that no public or serialized contract changes. No consumer layer depends on a CI job timeout, so no layer can go stale. The PR does not assert compatibility without evidence, because it makes no compatibility claim that needs cross-layer proof.

Full details: Modeling And Data Evidence

Explanation

The check is inapplicable. It covers formulas, selection logic, model or performance data, and predicted outputs. PR #863 (ai-dynamo/aisim, author saturley-hall) changes one line in a CI workflow. The diff inventory shows a single modified file, .github/workflows/pages.yml. The only hunk changes the build job timeout-minutes from 15 to 30 (around line 107). No formula, selection logic, dataset, model, or predicted output changes. The PR description also states that qualification and data selection are unchanged. The qualification evidence it cites (run 43491019429 timings) concerns runner timing, not modeling data, so no modeling provenance is required.

Full details: Compatibility Boundaries

Explanation

The check covers Python and Rust public surfaces, schemas, versions, bindings, documented defaults, AISim's standalone status relative to Dynamo, and the one-wheel plus one-crate artifact contract. The PR changes one line in .github/workflows/pages.yml: the build job timeout-minutes goes from 15 to 30 (confirmed via git diff on the reviewed range; --name-status lists only this file as modified). That file is a CI workflow for the Pages site. It does not touch Python or Rust sources, package metadata, versions, bindings, schemas, documented defaults, or artifact build and packaging config. The PR therefore introduces no change to any listed compatibility boundary. Result: PASS.

Full details: Review Evidence

Explanation

The PR description meets the Review evidence check. - Commands and results are named. It reports Actionlint v1.7.7 and git diff --check as passing locally, and it cites canonical deployment run 43491019429 with timestamps for each qualification stage. - Evidence types are distinguished. Local checks (Actionlint, git diff --check) are separate from the production run that motivated the change. Hosted preview/CI is stated as pending, and the canonical deployment is stated as to be rerun after merge. - No inactive nested workflow is cited as hosted CI evidence. The only run cited is the canonical production deployment, used as the failure reproduction. - Boundary evidence is present. The cited run shows the job canceled at the 15-minute limit, and the author states that failed builds may now hold a runner for up to 30 minutes. The description states that no new tests were added and why, which fits a low-risk, one-value change. - Gap, not a failure: the 30-minute limit itself is not yet exercised by any run. The description says the rerun follows merge. Verified in the diff: .github/workflows/pages.yml is the only file changed (1 insertion, 1 deletion). The build job's timeout-minutes changes from 15 to 30. The primary author is saturley-hall (verified).

Full details: Title check

Explanation

The title "ci: allow qualified Pages snapshots to finish" names the Pages workflow and the goal of letting snapshot preparation complete. It does not state the concrete behavioral change, which is raising the build job timeout from 15 to 30 minutes. The title is partially related to the change and is not vague, so it does not fail. It falls short of the title requirement to state the behavioral change precisely.

Resolution

Name the behavioral change directly, for example: "ci: raise Pages build job timeout from 15 to 30 minutes". This states the change and avoids vague wording.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f3713ba and 7a79ea0.

Files selected for processing: 1

  • .github/workflows/pages.yml
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 1 remain after this review.

Recent review details

Context from checks skipped due to timeout: 5

  • GitHub Check: Fast CI Success
  • GitHub Check: CodeRabbit
  • GitHub Check: Require Fast CI
  • GitHub Check: Repository Policy
  • GitHub Check: build
Additional context used

Code guidelines: 2

AGENTS.md — configured
REVIEW.md — configured
Path-based instructions: 4

Only root workflows are active.

CodeRabbit configuration file

Files:

  • .github/workflows/pages.yml
Read REVIEW.md before commenting.

CodeRabbit configuration file

Files:

  • .github/workflows/pages.yml
Source excerpt: Before adding code or other content copied, adapted, translated, or substantially derived from an external project, MUST: Add an entry to the root `THIRD_PARTY_NOTICES.md` identifying the derived files, upstream source and i...

CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/workflows/pages.yml
Source excerpt: Python describes and orchestrates work.

CodeRabbit inference engine (REVIEW.md)

Files:

  • .github/workflows/pages.yml

@saturley-hall
saturley-hall merged commit c268814 into main Nov 13, 2026
27 of 46 checks passed
@saturley-hall
saturley-hall deleted the ci/pages-qualification-timeout branch November 13, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant