Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Test on Python 3.13 beta #317

Merged
merged 1 commit into from
May 15, 2024
Merged

Travis CI: Test on Python 3.13 beta #317

merged 1 commit into from
May 15, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 11, 2024

The Python 3.13 release notes mention python-magic as one of the alternatives for imghdr which was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta.

https://www.python.org/downloads/release/python-3130b1/

May raise ModuleNotFoundError: No module named 'imghdr' because Python 3.13 removes it from the Standard Library.

imghdr: use the projects filetype, puremagic, or python-magic instead. (Contributed by Victor Stinner in gh-104773.)

https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals

The Python 3.13 release notes mention `python-magic` as one of the alternatives for `imghdr` which was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta.

https://www.python.org/downloads/release/python-3130b1/

May raise `ModuleNotFoundError: No module named 'imghdr'` because Python 3.13 removes it from the Standard Library.
* https://docs.python.org/3/library/imghdr.html

> imghdr: use the projects [filetype](https://pypi.org/project/filetype/), [puremagic](https://pypi.org/project/puremagic/), or [python-magic](https://pypi.org/project/python-magic/) instead. (Contributed by Victor Stinner in [gh-104773](python/cpython#104773).)

https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals
@ahupp ahupp merged commit 8eecfb7 into ahupp:master May 15, 2024
@ahupp
Copy link
Owner

ahupp commented May 15, 2024

Thanks!

@cclauss cclauss deleted the patch-1 branch May 15, 2024 05:42
@cclauss
Copy link
Contributor Author

cclauss commented May 15, 2024

Actually, Travis CI has never worked on this repo so the file .travis.yml can be deleted.

I created #318 to replace Travis CI.

@cclauss
Copy link
Contributor Author

cclauss commented May 15, 2024

In README.md the build badge links to the same place...

Build Status

cclauss added a commit to cclauss/python-magic that referenced this pull request May 16, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  ahupp#318
@cclauss cclauss mentioned this pull request May 16, 2024
ahupp pushed a commit that referenced this pull request May 16, 2024
As discussed at #317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  #318
cclauss added a commit to cclauss/python-magic that referenced this pull request May 20, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  ahupp#318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants