Skip to content

atdgen: migrate from bs to mel#54

Merged
jchavarri merged 2 commits into
masterfrom
migrate-bs-to-mel
Feb 20, 2025
Merged

atdgen: migrate from bs to mel#54
jchavarri merged 2 commits into
masterfrom
migrate-bs-to-mel

Conversation

@tatchi
Copy link
Copy Markdown
Contributor

@tatchi tatchi commented Feb 20, 2025

"melange" {>= "3.0.0"}
"atd"
"atdgen"
"atdgen" {>= "2.16.0"}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to bump the version here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. if we don't do this, the opam repo checks will fail.

@tatchi tatchi requested a review from jchavarri February 20, 2025 14:57
Copy link
Copy Markdown
Member

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! i had recently applied similar changes in #53 but didn't have time to extract in a separate PR.

"melange" {>= "3.0.0"}
"atd"
"atdgen"
"atdgen" {>= "2.16.0"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. if we don't do this, the opam repo checks will fail.

@jchavarri
Copy link
Copy Markdown
Member

Can you add new entry in CHANGELOG? That way, we can release a new version 4.0.0 with #53 as well.

@jchavarri jchavarri merged commit e1c20c9 into master Feb 20, 2025
@jchavarri jchavarri deleted the migrate-bs-to-mel branch February 20, 2025 16:00
jchavarri added a commit to jchavarri/opam-repository that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants