Fix version detection #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version detection fails since it's not strict enough. For example, given the PR title "Bump @fontsource/lato from 4.5.5 to 4.5.8": Both "from" and "to" versions are parsed as "4.5.5.", because the word "to" is included in the dependency name as well. Therefore, the corresponding regexes have been adapted to enforce a whitespace prior to the "from" and "to" terms.
|
Hi @ahmadnassri, is there any chance to get this merged soon? |
|
I'm also facing a similar issue with @ahmadnassri sorry for pinging you again, but is there any chance this could be merged and released? If you think that more work is needed in the form of unit tests, just let me know, I'm happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version detection fails since it's not strict enough. For example, given the PR title
Both
fromandtoversions are parsed as4.5.5, because the wordtois included in the dependency name as well. A real world example can be seen at https://github.com/eliashaeussler/typo3-badges/runs/6348654008?check_suite_focus=true.Solution: The corresponding regexes have been adapted to enforce a whitespace prior to the
fromandtoterms.Fixes #114.