Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies ending in "to" (eg "moto") are parsed incorrectly. #114

Open
eviltwin opened this issue Nov 23, 2021 · 0 comments · May be fixed by #139
Open

Dependencies ending in "to" (eg "moto") are parsed incorrectly. #114

eviltwin opened this issue Nov 23, 2021 · 0 comments · May be fixed by #139

Comments

@eviltwin
Copy link

I recently wondered why moto upgrades weren't merging automatically, and found that it was incorrectly identifying the "to" version:

title: "Bump moto from 2.2.15 to 2.2.16"
depName: moto
from: 2.2.15
to: 2.2.15
dependency type: production
security critical: false
config: all:semver:minor
Warning: no version range detected in PR title
manual merging required

it looks like the regex here is detecting the "to" at the end of "moto", followed by the \D swallowing the " from " portion of the title, leading to it grabbing the first semver in the title and not the second.

This could be fixed a number of ways, including using a single regex to parse the whole title or being stricter about what may appear in the \D position.

@eliashaeussler eliashaeussler linked a pull request Oct 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant