Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for http error 404: unable to login #122

Merged
merged 13 commits into from
Nov 23, 2021
Merged

Fix for http error 404: unable to login #122

merged 13 commits into from
Nov 23, 2021

Conversation

goegol
Copy link
Contributor

@goegol goegol commented Nov 19, 2021

Fix for http error 404: unable to login by mail
Login, receive the mail, accept it within 2 minutes and you are logged in!

Copy link
Contributor

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the indentation changes intended?

tgtg/__init__.py Outdated Show resolved Hide resolved
@Dielee
Copy link
Contributor

Dielee commented Nov 21, 2021

@ahivert will you merge my changes ?

@ahivert
Copy link
Owner

ahivert commented Nov 21, 2021

@ahivert will you merge my changes ?

Sorry missed that PR, can you please fix indentation with black ?

This project use pre-commit inside the project you have to run:

pre-commit install
pre-commit run -a

tgtg/__init__.py Outdated Show resolved Hide resolved
tgtg/__init__.py Outdated Show resolved Hide resolved
tgtg/__init__.py Outdated Show resolved Hide resolved
tgtg/__init__.py Outdated Show resolved Hide resolved
tgtg/__init__.py Outdated Show resolved Hide resolved
@ahivert
Copy link
Owner

ahivert commented Nov 21, 2021

@Dielee thanks for this PR ! Just some remarks to fix and please check that tests still works.
I will not ask you to add some tests (I will do it later) but keep existing tests green :)

@Dielee
Copy link
Contributor

Dielee commented Nov 22, 2021

@ahivert changed the requested changes, fixed black, but don't know how to fix the isort error...

@ahivert ahivert merged commit 31eb360 into ahivert:master Nov 23, 2021
@ahivert
Copy link
Owner

ahivert commented Nov 23, 2021

thanks @Dielee I will continue the work on #125 ;)

⚠️ CI on master is failing so please do not use master branch if you don't know what you do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants