Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align configs #69

Merged
merged 4 commits into from
May 11, 2024
Merged

Align configs #69

merged 4 commits into from
May 11, 2024

Conversation

ahembree
Copy link
Owner

Aligns configs in the default folder to those in the roles default folder (aka the advanced config)

@ahembree
Copy link
Owner Author

Decided to merge the cloudflare config files to reduce complexity. Initial PR had the API key defined the cloudflare.yml file, but it did not belong since it only is used by DDNS so it should've been in cloudflare_ddns.yml. I wanted to rename it to cloudflare_ddns_api_token, but that would break existing configs and require people to manually update their config files to the new variable name.

So, I ended up deciding to merge the files into a single cloudflare.yml to reduce any confusion on where cloudflare variables are defined

@ahembree ahembree merged commit 640d4d6 into master May 11, 2024
4 checks passed
@ahembree ahembree deleted the align-configs branch May 11, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant