Skip to content

Add Thrift 0.12 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahawkins merged 3 commits into from
Feb 6, 2019
Merged

Add Thrift 0.12 #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7302c73
Add Docker 0.12
Dec 29, 2018
2ef31bb
fixup! Add Docker 0.12
Jan 23, 2019
a30e3b1
fixup! Add Docker 0.12
jeking3 Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions 0.12/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
FROM ubuntu:18.04
Copy link
Copy Markdown
Contributor

@jeking3 jeking3 Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large image to start from. Why not use buildpack-deps:bionic-scm ?

Copy link
Copy Markdown
Contributor Author

@yuokada yuokada Jan 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A image using buildpack-deps is bigger than using ubuntu.

$ sudo docker images
REPOSITORY                 TAG                 IMAGE ID            CREATED             SIZE
tmp2                       latest              d1cc5d0e893c        10 seconds ago      317 MB  # <= FROM buildpack-deps
tmp                        latest              2ca50fa19b8a        5 minutes ago       151.9 MB   #  <= FROM ubuntu:18.04
docker.io/ubuntu           18.04               20bb25d32758        6 hours ago         87.47 MB
docker.io/buildpack-deps   bionic-scm          4b15e4cfafaf        3 weeks ago         247.9 MB

Copy link
Copy Markdown
Contributor

@jeking3 jeking3 Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - my mistake.


ENV THRIFT_VERSION v0.12.0

RUN buildDeps=" \
automake \
bison \
curl \
flex \
g++ \
libboost-dev \
libboost-filesystem-dev \
libboost-program-options-dev \
libboost-system-dev \
libboost-test-dev \
libevent-dev \
libssl-dev \
libtool \
make \
pkg-config \
"; \
apt-get update && apt-get install -y --no-install-recommends $buildDeps && rm -rf /var/lib/apt/lists/* \
&& curl -k -sSL "https://github.com/apache/thrift/archive/${THRIFT_VERSION}.tar.gz" -o thrift.tar.gz \
&& mkdir -p /usr/src/thrift \
&& tar zxf thrift.tar.gz -C /usr/src/thrift --strip-components=1 \
&& rm thrift.tar.gz \
&& cd /usr/src/thrift \
&& ./bootstrap.sh \
&& ./configure --disable-libs \
&& make \
&& make install \
&& cd / \
&& rm -rf /usr/src/thrift \
&& apt-get purge -y --auto-remove $buildDeps \
&& rm -rf /var/cache/apt/* \
&& rm -rf /var/lib/apt/lists/* \
&& rm -rf /tmp/* \
&& rm -rf /var/tmp/*


CMD [ "thrift" ]
Copy link
Copy Markdown
Contributor

@jeking3 jeking3 Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if this container did not run thrift as root.

There's a good recipe for running inside a container as a regular user in the Boost Docker Development Environment.