Skip to content

Commit

Permalink
Fix dangling log_output in Service (SeleniumHQ#12871)
Browse files Browse the repository at this point in the history
The isinstance check was faulty and checked wrong type

Fixes SeleniumHQ#12870
  • Loading branch information
alexey-pelykh authored and aguspe committed Oct 22, 2023
1 parent 984f5ca commit 00ef7d1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions py/selenium/webdriver/common/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
import typing
from abc import ABC
from abc import abstractmethod
from io import IOBase
from platform import system
from subprocess import PIPE
from time import sleep
from typing import TextIO
from urllib import request
from urllib.error import URLError

Expand Down Expand Up @@ -136,7 +136,7 @@ def stop(self) -> None:
"""Stops the service."""

if self.log_output != PIPE:
if isinstance(self.log_output, TextIO):
if isinstance(self.log_output, IOBase):
self.log_output.close()
elif isinstance(self.log_output, int):
os.close(self.log_output)
Expand Down

0 comments on commit 00ef7d1

Please sign in to comment.