Added an exception handler in the asyncio test runner #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now raise all the capture exceptions if the test function completes without raising any exceptions of its own. Closes #205.
graingert
reviewed
Mar 2, 2021
graingert
reviewed
Mar 2, 2021
graingert
reviewed
Mar 3, 2021
tests/test_pytest_plugin.py
Outdated
Comment on lines
86
to
87
| result.assert_outcomes(passed=3 * len(get_all_backends()) + 1, skipped=len(get_all_backends()), | ||
| failed=1) |
There was a problem hiding this comment.
I'd expect test_asyncio_exception_handler to pass, then fail in teardown:
Suggested change
| result.assert_outcomes(passed=3 * len(get_all_backends()) + 1, skipped=len(get_all_backends()), | |
| failed=1) | |
| result.assert_outcomes(passed=3 * len(get_all_backends()) + 2, skipped=len(get_all_backends()), | |
| failed=1) |
There was a problem hiding this comment.
Why? The exception is raised during the actual test run (albeit in a callback), not during fixture teardown.
|
I'll merge this tomorrow unless you have some concerns left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will now raise all the capture exceptions if the test function completes without raising any exceptions of its own.
Closes #205.