-
Notifications
You must be signed in to change notification settings - Fork 0
Fix ERC-8040 validation errors: Update links and interface name #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated description in header - Changed interface name from IESCG8040 to IERC8040 - Added proper links to ERC-20, ERC-721, and ERC-1155 references - Removed unnecessary sections (Motivation, Backwards Compatibility, Test Cases, Reference Implementation, Changelog, Compliance Notes) - Simplified structure to focus on core specification - Updated discussions-to URL Co-authored-by: agronetlabs <[email protected]>
- Changed ERC-20, ERC-721, and ERC-1155 links from absolute URLs to relative paths (./eip-20.md, ./eip-721.md, ./eip-1155.md) - All validator checks now pass (eipw, markdownlint) Co-authored-by: agronetlabs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Purpose: Align ERC-8040 proposal file with ERC/EIP validator requirements and correct interface/links for ERC-20/721/1155.
- Normalize front matter and section structure to meet validator expectations
- Fix interface name to IERC8040 and update content/links for ERC-20/721/1155
- Streamline content and examples
Comments suppressed due to low confidence (2)
ERCS/erc-8040.md:54
- The interface defines carbon_value as uint256, but the JSON example shows a fractional value. Document a fixed-point convention (e.g., 18 decimals) and require carbon_value in base units as an integer, or adjust the field to represent scaled values consistently across the spec.
uint256 carbon_value;
ERCS/erc-8040.md:102
- Update the example to match the interface: use an integer base-unit value for carbon_value (per the documented scaling) and represent digest consistently with the chosen on-chain type (e.g., 0x-prefixed 32-byte hex for bytes32, or 0x-prefixed 64-byte hex for SHA3-512 in 'bytes').
"category": "carbon",
"geo": "BR-RS",
"carbon_value": 12.5,
"digest": "sha3-512:abc123def456..."
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aproved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aproved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
This PR fixes validation errors in the ERC-8040 ESG Tokenization Protocol proposal to ensure it passes the ethereum/ERCs automated validator.
Changes Made
1. Fixed ERC Reference Links
Changed ERC-20, ERC-721, and ERC-1155 references from absolute URLs to relative paths as required by the
markdown-rel-linksvalidator:[ERC-20](https://eips.ethereum.org/EIPS/eip-20)→[ERC-20](./eip-20.md)[ERC-721](https://eips.ethereum.org/EIPS/eip-721)→[ERC-721](./eip-721.md)[ERC-1155](https://eips.ethereum.org/EIPS/eip-1155)→[ERC-1155](./eip-1155.md)2. Corrected Interface Name
Fixed the Solidity interface name from
IESCG8040toIERC8040to match the ERC number convention.3. Streamlined Content
licensefield from preamble (not required in preamble order)4. Improved Structure
#to##format for proper hierarchyValidation Results
All automated validators now pass:
erc-8040.mdThis PR ensures the ERC-8040 proposal complies with all ethereum/ERCs repository standards and will pass CI/CD validation checks.
Closes #[issue-number]
Original prompt
Corrigir o arquivo de proposta ERC para que o build do repositório ethereum/ERCs passe no validador automático. 1. O nome do arquivo deve ser erc-8040.md (não eip-8040.md), refletindo o header 'eip: 8040'. 2. Todas as menções a ERC-20, ERC-721, ERC-1155 devem ser links para o padrão correspondente. Substituir o arquivo ERCS/erc-8040.md pelo conteúdo abaixo, garantindo que os links estejam corretos e o nome do arquivo seja erc-8040.md. Este PR resolve todos os erros do validador.
Arquivo corrigido:
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.