Skip to content

Conversation

@agorbulin
Copy link
Owner

Original Pull Request

magento#19029
…ged-in

magento#18901: Forgot password form should not available while customer is logged in

Description (magento#18901)

When you is logged in, form forgotpassword not shown, redirect to My Account occurred instead
When you guest and go to forgotpassword form, you see forgotpassword form

Fixed Issues (magento#18901)

  1. Forgot password form should not available while customer is logged in. magento/magento2#18901: Forgot password form should not available while customer is logged in

Manual testing scenarios (*)

  1. Go to customer/account/forgotpassword as guest
  2. See forgotpassword form
  3. Login as user on FE
  4. Go to customer/account/forgotpassword
  5. You do not see forgotpassword form, but you redirected to My Account

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Janak Bhimani and others added 30 commits October 16, 2018 11:02
# Conflicts:
#	app/code/Magento/SalesRule/Test/Mftf/Section/AdminCartPriceRulesFormSection.xml
# Conflicts:
#	app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml
#	app/code/Magento/Store/Test/Mftf/Data/WebsiteData.xml
… value of "GB" provided for the regionId field.
al.kravchuk and others added 16 commits November 2, 2018 17:01
…nclude download links.

- move save downloadable items from 'save_commit_after' to 'save_after' event.
Accepted Public Pull Requests:
 - magento#18984: [Backport] Reload cart totals when cart data changes (by @tdgroot)
 - magento#18908: [Backport] fixed - Unable to select payment method according to country of the address at checkout time (by @rahulwebkul)


Fixed GitHub Issues:
 - magento#18907: Unable to select payment method according to country of the address at checkout time (reported by @rahulwebkul) has been fixed in magento#18908 by @rahulwebkul in 2.2-develop branch
   Related commits:
     1. f1b2360
…ult upon save magento#19012

 - Merge Pull Request magento#19012 from RostislavS/magento2:issue18348
 - Merged commits:
   1. 468f245
   2. 4c13ad7
…ut d… magento#19036

 - Merge Pull Request magento#19036 from swnsma/magento2-1:Save-Downloadable-Product-Links-For-Order-Items
 - Merged commits:
   1. 429815b
…rder data magento#16684 magento#18857

 - Merge Pull Request magento#18857 from ssp58bleuciel/magento2:fixed-issue-16684
 - Merged commits:
   1. 5a84c5a
   2. e4b430a
Accepted Public Pull Requests:
 - magento#19036: magento#18323: Order confirmation email for guest checkout d� (by @swnsma)
 - magento#19012: magento#18348 - In admin, last swatch option set to default upon save (by @RostislavS)
 - magento#18964:  Backport [PR 18772] Remove unnecesary "header" block redeclaration (by @samuel27m)
 - magento#18857: Fixed - Default tax region/state appears in customer & order data magento#16684 (by @ssp58bleuciel)
 - magento#16887: Fix blocked a frame with origin (by @iGerchak)
 - magento-engcom/magento2ce#1169: magento#12970: Can't add grouped product, with out of stock sub product, to cart. (by @p-bystritsky)


Fixed GitHub Issues:
 - magento#18323: Order confirmation email for guest checkout does not include download links (reported by @hsray) has been fixed in magento#19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - magento#19003: salesInvoiceOrder REST API does not make downloadable products available (reported by @nthurston) has been fixed in magento#19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - magento#19034: sales_order_item_save_commit_after and sales_order_save_commit_after events will never fire for guest checkout (reported by @swnsma) has been fixed in magento#19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - magento#8348: 1 exception(s): Exception #0 (Exception): Warning: Invalid argument supplied for foreach() in NotProtectedExtension.php on line 89 (reported by @craigcarnell) has been fixed in magento#19012 by @RostislavS in 2.2-develop branch
   Related commits:
     1. 468f245
     2. 4c13ad7

 - magento#16684: Default tax region/state appears in customer & order data (reported by @Detzler) has been fixed in magento#18857 by @ssp58bleuciel in 2.2-develop branch
   Related commits:
     1. 5a84c5a
     2. e4b430a

 - magento#12970: Can't add grouped product, with out of stock sub product, to cart (reported by @breg-13) has been fixed in magento-engcom/magento2ce#1169 by @p-bystritsky in 2.2-develop branch
   Related commits:
     1. 7d44656
     2. 42b4f3c
     3. da05e92
     4. 40600b9
     5. 63c7fc9
     6. 26b6a27
agorbulin pushed a commit that referenced this pull request Nov 6, 2018
agorbulin pushed a commit that referenced this pull request Nov 6, 2018
agorbulin pushed a commit that referenced this pull request Nov 6, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
…ged-in magento#18901: Forgot password form should not available while customer is logged in
@agorbulin agorbulin force-pushed the 2.2-develop-PR-port-19029 branch from 6ce920c to 8ae5b87 Compare November 6, 2018 21:37
agorbulin pushed a commit that referenced this pull request Nov 6, 2018
Remove unnecesary "header" block redeclaration
agorbulin pushed a commit that referenced this pull request Nov 22, 2018
agorbulin pushed a commit that referenced this pull request Nov 22, 2018
agorbulin pushed a commit that referenced this pull request Dec 8, 2018
agorbulin pushed a commit that referenced this pull request Dec 8, 2018
agorbulin pushed a commit that referenced this pull request Dec 21, 2018
agorbulin pushed a commit that referenced this pull request Dec 22, 2018
agorbulin pushed a commit that referenced this pull request Dec 22, 2018
Missing setTotalCount on $searchResults object in getList method
agorbulin pushed a commit that referenced this pull request Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.