Skip to content

Add Catalyst document picker host (PR 20/20) - #70

Merged
agoodkind merged 1 commit into
allow-catalyst-read-only-user-filesfrom
stabilize-catalyst-document-picker
Jul 25, 2026
Merged

agoodkind merged 1 commit into
allow-catalyst-read-only-user-filesfrom
stabilize-catalyst-document-picker

Conversation

@agoodkind

@agoodkind agoodkind commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

This change gives Mac Catalyst a stable UIKit document picker host. Import no longer shares SwiftUI sheet ownership with other config-library presentations.

Change

The host owns request identity, one active picker, delegate completion, and dismissal completion. Import stays disabled until the picker and import lifecycle return to idle.

The iPhone surface remains read-only and unchanged.

Testing

  • make lint
  • make test
  • make build-catalyst-ci CONFIG=Debug
  • Tart Mac Catalyst UI matrix: 5 passed, 0 failed
  • Tart iPhone UI matrix: 2 passed, 0 failed
  • The Catalyst matrix covered cancel, repeated cancel, valid real-file import, invalid real-file recovery, scrolling, and continued button interaction

@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: fcaa7dfb-55cb-4b52-a640-82573e84f9e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stabilize-catalyst-document-picker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agoodkind agoodkind changed the title Add Catalyst document picker host Add Catalyst document picker host (PR 20/20) Jul 24, 2026
@agoodkind
agoodkind marked this pull request as ready for review July 24, 2026 07:53
Copilot AI review requested due to automatic review settings July 24, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 16:30
@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from 8875bb3 to fb6003e Compare July 24, 2026 16:30
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from c20f995 to f2e19a8 Compare July 24, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agoodkind
agoodkind changed the base branch from allow-catalyst-read-only-user-files to graphite-base/70 July 24, 2026 22:31
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from f2e19a8 to 6c7bb66 Compare July 24, 2026 22:36
Copilot AI review requested due to automatic review settings July 24, 2026 22:36
@agoodkind
agoodkind changed the base branch from graphite-base/70 to allow-catalyst-read-only-user-files July 24, 2026 22:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from 34e9da7 to f42be5b Compare July 24, 2026 23:30
Copilot AI review requested due to automatic review settings July 24, 2026 23:30
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from 6c7bb66 to 792284d Compare July 24, 2026 23:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 23:48
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from 792284d to c691bca Compare July 24, 2026 23:48
@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from f42be5b to 830a3a1 Compare July 24, 2026 23:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 25, 2026 00:32
@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from 830a3a1 to f68415e Compare July 25, 2026 00:32
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from c691bca to ce88210 Compare July 25, 2026 00:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from f68415e to 8dfa10f Compare July 25, 2026 05:20
Copilot AI review requested due to automatic review settings July 25, 2026 05:20
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from ce88210 to 30a5854 Compare July 25, 2026 05:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Co-authored-by: Codex <noreply@openai.com>
Copilot AI review requested due to automatic review settings July 25, 2026 05:48
@agoodkind
agoodkind force-pushed the stabilize-catalyst-document-picker branch from 30a5854 to 8877ab5 Compare July 25, 2026 05:48
@agoodkind
agoodkind force-pushed the allow-catalyst-read-only-user-files branch from 8dfa10f to a205843 Compare July 25, 2026 05:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agoodkind
agoodkind merged commit 6c689be into allow-catalyst-read-only-user-files Jul 25, 2026
4 checks passed
@agoodkind
agoodkind deleted the stabilize-catalyst-document-picker branch July 25, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants