Add manufacturer to prefname. #352
Conversation
There was a problem hiding this comment.
Nice idea, and might be worth expanding in future to some more tag and watch makers.
I think we could replace bermuda_ with the slugified manufacturers name, eg tile_aa_dd_ff_44_33_55 (Tile) since the bermuda part was only there to make it obvious where some random mac-named entity came from.
| device.name | ||
| or device.local_name | ||
| or f"{DOMAIN}_{slugify(device.address)}{f" ({slugify(device.manufacturer)}) " | ||
| if device.manufacturer else ""}" |
There was a problem hiding this comment.
This is a me thing not a you thing, but I am having very strong visceral reactions to this ternary! Can you re-write it as a classic if-then-else? I keep trying to parse it and just get frustrated before getting anywhere 😅 I can't tell if it does what I expect because the surrounding indentation and quoting and parens make the usually smelly ternary thoroughly opaque to me! It might be an adhd limited working-set-memory thing, but I just don't have the stack space in my own brain for it, sorry! I feel like beyond a single line it's an antipattern.
While there... what do you think about ditching the {DOMAIN}_ part and replacing that with the slugified manu name as well? eg: tile_44_55_11_22_33 which is probably more helpful for users. I only put the domain in there because I didn't want to create entries with just a bare mac address, so having the manufacturer name prefixed (when available) I think is a better user-experience.
There was a problem hiding this comment.
Yeah replacing domain is a good call.
I removed the ternary.
I also added the whole list of member uuids. Maybe in the future we could setup a github action to automatically check for updates like once a week?
Co-authored-by: Ashley Gittins <[email protected]>
agittins
force-pushed
the
prefname_improvements
branch
from
3e248cc to
04e2dcb
Compare
What spawned my conversation with you was that I got a tile for tracking my dog, and I struggled to find it a bit with Bermuda since it didn't have a name attached. I think adding manufacturer name to the end of a prefname when we don't have a real name and we are just making one up is a good step to help users figure out where the device they want to add is.