Upgrade devDeps to React 18 -- needs to update tests, peers, etc. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to React 18
This comment was marked as spam.
This comment was marked as spam.
agilgur5
changed the title
agilgur5
added
solution: invalid
scope: dependencies
agilgur5
reviewed
May 4, 2022
There was a problem hiding this comment.
Please see #76 (comment) -- there is quite a bit more that needs to change. If it were this simple, I would have upgraded it already, but unfortunately, it is not.
In particular, tests and CI will almost certainly fail on this as, per the above link, there is no Enzyme adapter for React 18. Which also means that we can't test that React 18 actually works without issues without updating the test harness.
Repository owner
locked as resolved and limited conversation to collaborators
May 4, 2022
agilgur5
added
the
kind: internal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to React 18