プロジェクトメンバー追加時、検索するとチェックが外れる（Feature #71439） #14
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusohiro
force-pushed
the
71439-fix-unchecking-issue-on-member-search
branch
from
a083f6d to
cc2accb
Compare
nusohiro
force-pushed
the
71439-fix-unchecking-issue-on-member-search
branch
from
8c0b0f9 to
97fa95e
Compare
|
Patch can be downloaded here |
|
手元ではテストがとおりましたが、以下の対応がまだできていないので、CIでテストが落ちています。 |
kumojima
reviewed
May 9, 2024
| $('#principals').find('input[type="checkbox"]').closest('label').hide() | ||
| <% principals_for_new_member_ids(@project)&.map do |member| %> | ||
| $('#principals').find('input[type="checkbox"][value=<%= member.id %>]').closest('label').show() | ||
| <% end %> |
There was a problem hiding this comment.
#principals_for_new_member の中身をまるっと書き換えていたのを、いったん非表示にして検索結果として返ってきたものを再度表示するという仕組みでチェック状態を保存していると理解しました 👍
初期状態で limit=100 に制限されていると思うので、そこで表示しきれなかったユーザーにチェックできるかが気になりました
本パッチとは別にして提案しても良いかもしれませんね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redmine.orgのチケットURL: https://www.redmine.org/issues/xxxx
story
https://insidemine.agileware.jp/redmine/issues/71439
内容
・名前検索後もチェックが外れないように修正
2024-02-05.12.02.33-1.mov
・選択済みのユーザーを表示する領域を追加← UIの変更は取り込まれなさそうな気がして、やっぱりやめます