Add libcamera and libcamera-apps to recipes-multimedia #963
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| SUMMARY = "Raspberry libcamera-apps" | ||
|
|
||
| LICENSE = "BSD-2-Clause" | ||
| LIC_FILES_CHKSUM = "file://license.txt;md5=a0013d1b383d72ba4bdc5b750e7d1d77" | ||
|
|
||
| SRC_URI = "git://github.com/raspberrypi/libcamera-apps.git;branch=main;protocol=https" | ||
|
|
||
| PV = "1.0+git${SRCPV}" | ||
| SRCREV = "11c5203a202777ddc339bba1dd8f85b53b60c279" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
|
|
||
| DEPENDS = "libcamera opencv boost libjpeg-turbo libexif tiff" | ||
| RDEPENDS:${PN} = "libcamera opencv boost libjpeg-turbo libexif tiff python3-core" | ||
|
Owner
There was a problem hiding this comment. Do we need these RDEPENDS? The packaging should be able to infer them without having them explicit. Any issues with that? |
||
|
|
||
| inherit cmake pkgconfig | ||
|
|
||
| EXTRA_OECMAKE = "${@bb.utils.contains("DISTRO_FEATURES", "x11", "-DENABLE_X11=1", "-DENABLE_X11=0", d)} \ | ||
|
Owner
There was a problem hiding this comment. This would be nicer to handle as a |
||
| ${@bb.utils.contains("MACHINE", "raspberrypi3", "-DENABLE_COMPILE_FLAGS_FOR_TARGET=armv8-neon", "", d)} \ | ||
| ${@bb.utils.contains("MACHINE", "raspberrypi4", "-DENABLE_COMPILE_FLAGS_FOR_TARGET=armv8-neon", "", d)} \ | ||
| " | ||
|
|
||
| PACKAGECONFIG[qt] = "-DENABLE_QT=1" | ||
|
Owner
There was a problem hiding this comment. Can we have the explicit disable as well for all these PACKAGECONFIG entries? |
||
| PACKAGECONFIG[opencv] = "-DENABLE_OPENCV=1" | ||
| PACKAGECONFIG[tensorflow-lite] = "-DENABLE_TFLITE=1" | ||
|
|
||
| COMPATIBLE_MACHINE = "^rpi$" | ||
|
|
||
| FILES:${PN}-dev = "${includedir} ${libdir}/pkgconfig" | ||
|
Owner
There was a problem hiding this comment. This should be in by default hence not needed. |
||
| FILES:${PN} += "${libdir}/libpreview.so" | ||
|
Owner
There was a problem hiding this comment. We can remove this and all the following using |
||
| FILES:${PN} += "${libdir}/libencoders.so" | ||
| FILES:${PN} += "${libdir}/liboutputs.so" | ||
| FILES:${PN} += "${libdir}/libimages.so" | ||
| FILES:${PN} += "${libdir}/libpost_processing_stages.so" | ||
| FILES:${PN} += "${libdir}/libcamera_app.so" | ||
agherzan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such version as far as I can see. I don't see any 1.0 tags in the repo. Just use
gitin the recipe filename.