Skip to content

Create DevMode proxy through Gravity #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create DevMode proxy through Gravity #469

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
faa6326
Add support for devmode proxy
jhaynie Oct 13, 2025
a591b5d
default on
jhaynie Oct 13, 2025
d7db2da
turn down logging
jhaynie Oct 13, 2025
ff00ee7
pr feedback
jhaynie Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions cmd/dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,24 +126,32 @@ Examples:
log.Fatal("failed to find available port: %s", err)
}

connectProxyPort, _ := cmd.Flags().GetInt("proxy-port")
var connectProxyPortPtr *uint
if connectProxyPort > 0 {
port := uint(connectProxyPort)
connectProxyPortPtr = &port
}

Comment on lines 129 to 138
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Default enables proxy despite “disabled if zero” description (and PR states default disabled)

Current default 19081 enables the CONNECT proxy by default. Either set default to 0 (and keep description), or update description/PR to reflect enabled-by-default. Also validate port range.

Apply this diff to make it disabled by default and validate:

-	connectProxyPort, _ := cmd.Flags().GetInt("proxy-port")
+	connectProxyPort, _ := cmd.Flags().GetInt("proxy-port")
+	if connectProxyPort < 0 || connectProxyPort > 65535 {
+		log.Fatal("invalid --proxy-port: %d (must be 0-65535)", connectProxyPort)
+	}
 	var connectProxyPortPtr *uint
 	if connectProxyPort > 0 {
 		port := uint(connectProxyPort)
 		connectProxyPortPtr = &port
 	}
-	devCmd.Flags().Int("proxy-port", 19081, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
+	devCmd.Flags().Int("proxy-port", 0, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")

Also applies to: 319-319

server, err := dev.New(dev.ServerArgs{
APIURL: apiUrl,
APIKey: apiKey,
Hostname: endpoint.Hostname,
Config: &gravity.Config{
Context: ctx,
Logger: log,
Version: Version,
OrgID: orgId,
Project: theproject,
EndpointID: endpoint.ID,
URL: gravityUrl,
SDKKey: project.Secrets["AGENTUITY_SDK_KEY"],
ProxyPort: uint(proxyPort),
AgentPort: uint(agentPort),
Ephemeral: true,
ClientName: "cli/devmode",
DynamicHostname: true,
Context: ctx,
Logger: log,
Version: Version,
OrgID: orgId,
Project: theproject,
EndpointID: endpoint.ID,
URL: gravityUrl,
SDKKey: project.Secrets["AGENTUITY_SDK_KEY"],
ProxyPort: uint(proxyPort),
AgentPort: uint(agentPort),
ConnectProxyPort: connectProxyPortPtr,
Ephemeral: true,
ClientName: "cli/devmode",
DynamicHostname: true,
},
})
if err != nil {
Expand Down Expand Up @@ -308,6 +316,7 @@ func init() {
rootCmd.AddCommand(devCmd)
devCmd.Flags().StringP("dir", "d", ".", "The directory to run the development server in")
devCmd.Flags().Int("port", 0, "The port to run the development server on (uses project default if not provided)")
devCmd.Flags().Int("proxy-port", 19081, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Default should be disabled to match PR description and avoid unexpected proxy start

The flag help says “disabled if zero,” but default 19081 enables it by default. Consider defaulting to 0.

Apply this diff:

-	devCmd.Flags().Int("proxy-port", 19081, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
+	devCmd.Flags().Int("proxy-port", 0, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
devCmd.Flags().Int("proxy-port", 19081, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
devCmd.Flags().Int("proxy-port", 0, "The port to run the HTTP CONNECT proxy server on (disabled if zero)")
🤖 Prompt for AI Agents 
In cmd/dev.go around line 320, the proxy-port flag currently defaults to 19081
which contradicts the help text saying "disabled if zero"; change the flag's
default value from 19081 to 0 so the proxy is disabled by default, leaving the
flag name, type, and help string unchanged.

devCmd.Flags().Bool("no-build", false, "Do not build the project before running it (useful for debugging)")
devCmd.Flags().MarkHidden("no-build")
}
Loading
Loading