-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests should clear (or not use) local repo caches #329
Comments
…not sure there are other tests besides the 2 that I updated in this commit that need to clear the local repo cache as well.
…not sure there are other tests besides the 2 that I updated in this commit that need to clear the local repo cache as well.
…django webapp, add local repo cache clearing to webapp tests which further addresses agentos-project#329.
Copying this text over from a comment in #310: Clearing these caches can be tricky if modules that live in them have already been loaded into a python process. Just ran into this when trying to update the tests to clear the repo cache, but then Windows (though not Linux or MacOs) threw an exception during test_component_from_github_no_venv when trying to clear the cache because test_component_from_github_with_venv had already run and loaded some modules from that same local github repo. I now think perhaps we should only cache repos locally into directories that have the name of the github hash, and then we can also separately cache the mapping between branch names and repos. Dulwich might also have a better way of handling these things. |
See discussion in #310
The text was updated successfully, but these errors were encountered: